Cleanup prior to PR

Author: harperaa

.gitignore

@@ -11,6 +11,8 @@ packages/plugin-buttplug/intiface-engine
 .DS_Store
 shawdocs/
 dist/
+
+foo.txt
 # Allow models directory but ignore model files
 models/*.gguf
 

characters/shaiw.character.json

@@ -1,7 +1,7 @@
 {
     "name": "ShaiwCodeAssistant",
     "description": "I am an AI assistant specialized in helping developers contribute to Eliza. I can help with documentation, getting started, and answering common development questions.",
-    "clients": [],
+    "clients": ["discord"],
     "modelProvider": "anthropic",
     "model": "claude-3-sonnet-20240229",
     "plugins": ["@elizaos/plugin-code-assistant"],

packages/plugin-code-assistant/README.md

@@ -20,34 +20,44 @@ This plugin provides code assistance functionality for Shaiw, alter ego of Shaw,
 
 ## Installation
 
-1. Adjust the `shaiw.character.json` in `characters` folder to your liking
+0. Setup the discord bot: [Discord guide here](https://discordjs.guide/preparations/setting-up-a-bot-application.html#creating-your-bot)
 
-2. update .env with your:
+1. Setup Discord bot intents, select app, then select bot menu on the left, then scroll down and enable:
+
+- Persistence Intent
+- Server Members Intent
+- Message Content Intent
+
+Hit save.
+
+2. Adjust the `shaiw.character.json` in `characters` folder to your liking
+
+3. update .env with your:
 
 - ANTHROPIC_API_KEY
 - GITHUB_TOKEN
 - DISCORD_APPLICATION_ID
 - DISCORD_API_TOKEN
 
-3. Standard install and build:
+4. Standard install and build:
 
 ```
 pnpm clean && pnpm install && pnpm build
 ```
 
-4. Run the plugin:
+5. Run the plugin:
 
 ```
 pnpm start --characters characters/shaiw.character.json
 ```
 
-5. Run the plugin (with new database)
+6. Run the plugin (with new database)
 
 ```
 pnpm cleanstart --characters characters/shaiw.character.json
 ```
 
-6. Run the plugin (with new database and in debug mode)
+7. Run the plugin (with new database and in debug mode)
 
 ```
 pnpm cleanstart:debug --characters characters/shaiw.character.json

packages/plugin-code-assistant/src/actions/githubActions.ts

@@ -9,7 +9,6 @@ import {
     State,
     ActionExample,
     stringToUuid,
-    getEmbeddingZeroVector,
     embed,
 } from "@elizaos/core";
 import { Octokit } from "@octokit/rest";
@@ -57,6 +56,13 @@ export async function crawlDocumentation(runtime: IAgentRuntime) {
 
             // Create document memory with URL
             const docId = stringToUuid(url);
+            const initialEmbedding = await embed(runtime, mainContent);
+            if (!initialEmbedding || initialEmbedding.length === 0) {
+                elizaLogger.warn(
+                    "Empty embedding generated, skipping memory creation"
+                );
+                return;
+            }
             await runtime.documentsManager.createMemory({
                 id: docId,
                 agentId: runtime.agentId,
@@ -68,7 +74,7 @@ export async function crawlDocumentation(runtime: IAgentRuntime) {
                     source: "documentation",
                     url: url,
                 },
-                embedding: getEmbeddingZeroVector(),
+                embedding: initialEmbedding,
             });
 
             // Split into chunks and create vector embeddings
@@ -131,7 +137,6 @@ const REPO_NAME = "eliza";
 
 // Increase timeout
 const TIMEOUT_MS = 30000; // 30 seconds timeout
-const MAX_RETRIES = 2;
 let type = "Issue";
 // Add request tracking helper
 class RequestTracker {
@@ -496,15 +501,36 @@ export const githubAction: Action = {
                     }
 
                     if (llmResponse?.text) {
+                        const responseText = llmResponse.text;
+                        const responseEmbedding = await embed(
+                            runtime,
+                            responseText
+                        );
+
+                        if (
+                            !responseEmbedding ||
+                            responseEmbedding.length === 0
+                        ) {
+                            elizaLogger.warn(
+                                "Empty response embedding generated, skipping memory creation"
+                            );
+                            callback({
+                                text: responseText,
+                                metadata: { requestId },
+                            });
+                            return;
+                        }
+
                         const responseMessage = {
                             content: {
-                                text: llmResponse.text,
+                                text: responseText,
                                 source: "github",
                                 attachments: [],
                             },
                             userId: runtime.agentId,
                             roomId: message.roomId,
                             agentId: runtime.agentId,
+                            embedding: responseEmbedding,
                         };
                         await runtime.messageManager.createMemory(
                             responseMessage
@@ -598,4 +624,5 @@ export const githubAction: Action = {
             },
         ],
     ] as ActionExample[][],
-} as Action;
+
+} as Action;