Skip to content

Commit 701da00

Browse files
meteorcloudyjasonaden
authored andcommitted
build: Remove --watchfs from bazelrc file (angular#29635)
--watchfs is causing the build to be flaky on Windows because Bazel doesn't have proper support for watchfs on Windows, but it doesn't seem to bring much performance on Linux, either. Fixes: angular#29541 PR Close angular#29635
1 parent f9497bf commit 701da00

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

.bazelrc

+3-2
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,9 @@ test:debug --test_arg=--node_options=--inspect-brk --test_output=streamed --test
3535
# See https://github.com/bazelbuild/bazel/issues/4603
3636
build --symlink_prefix=dist/
3737

38-
# Performance: avoid stat'ing input files
39-
build --watchfs
38+
# Disable watchfs as it causes tests to be flaky on Windows
39+
# https://github.com/angular/angular/issues/29541
40+
build --nowatchfs
4041

4142
# Turn off legacy external runfiles
4243
run --nolegacy_external_runfiles

.codefresh/bazel.rc

-4
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,6 @@ build --verbose_failures=true
3636
build --action_env=PATH
3737
test --action_env=PATH --test_env=PATH
3838

39-
# Disable watchfs on Windows as it causes tests to be flaky
40-
# https://github.com/angular/angular/issues/29541
41-
build --nowatchfs
42-
4339
# Exclude tests known to not work on Windows.
4440

4541
# Chrome web tests are currently broken.

0 commit comments

Comments
 (0)