Skip to content

Commit d766ad0

Browse files
devversionmhevery
authored andcommitted
build: update gulp-clang-format dependency (angular#27712)
Currently rnning the gulp tasks to format code does not work because the `through2` version used by `gulp-clang-format` is very outdated and seems to cause exceptions like: ``` Error: no writecb in Transform class at afterTransform (C:\Users\Paul\projects\angular\node_modules\gulp-clang-format\node_modules\readable-stream\lib\_stream_transform.js:95:33) at TransformState.afterTransform (C:\Users\Paul\projects\angular\node_modules\gulp-clang-format\node_modules\readable-stream\lib\_stream_transform.js:79:12) ``` Updating to the latest version of `gulp-clang-format` that comes with angular/gulp-clang-format@10cbb7f, seems to fix this. **Note**: This issue seems to depend on the platform because I didn't run into it on MacOS, or Linux. Though I got the failure on Windows. I didn't spend time investigating, but updating to the latest version should just improve things. PR Close angular#27712
1 parent f57916c commit d766ad0

File tree

2 files changed

+10
-21
lines changed

2 files changed

+10
-21
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@
110110
"firefox-profile": "1.0.3",
111111
"glob": "7.1.2",
112112
"gulp": "3.9.1",
113-
"gulp-clang-format": "1.0.23",
113+
"gulp-clang-format": "1.0.27",
114114
"gulp-connect": "5.0.0",
115115
"gulp-conventional-changelog": "^2.0.3",
116116
"gulp-filter": "^5.1.0",

yarn.lock

+9-20
Original file line numberDiff line numberDiff line change
@@ -3482,18 +3482,17 @@ graphviz@0.0.7:
34823482
dependencies:
34833483
temp "~0.4.0"
34843484

3485-
gulp-clang-format@1.0.23:
3486-
version "1.0.23"
3487-
resolved "https://registry.yarnpkg.com/gulp-clang-format/-/gulp-clang-format-1.0.23.tgz#fe258586b83998491e632fc0c4fc0ecdfa10c89f"
3488-
integrity sha1-/iWFhrg5mEkeYy/AxPwOzfoQyJ8=
3485+
gulp-clang-format@1.0.27:
3486+
version "1.0.27"
3487+
resolved "https://registry.yarnpkg.com/gulp-clang-format/-/gulp-clang-format-1.0.27.tgz#c89716c26745703356c4ff3f2b0964393c73969e"
3488+
integrity sha512-Jj4PGuNXKdqVCh9fijvL7wdzma5TQRJz1vv8FjOjnSkfq3s/mvbdE/jq+5HG1c/q+jcYkXTEGkYT3CrdnJOLaQ==
34893489
dependencies:
34903490
clang-format "^1.0.32"
3491+
fancy-log "^1.3.2"
34913492
gulp-diff "^1.0.0"
3492-
gulp-util "^3.0.4"
3493-
pkginfo "^0.3.0"
3493+
plugin-error "^1.0.1"
34943494
stream-combiner2 "^1.1.1"
3495-
stream-equal "0.1.6"
3496-
through2 "^0.6.3"
3495+
through2 "^2.0.3"
34973496

34983497
gulp-connect@5.0.0:
34993498
version "5.0.0"
@@ -3562,7 +3561,7 @@ gulp-tslint@8.1.2:
35623561
map-stream "~0.0.7"
35633562
through "~2.3.8"
35643563

3565-
gulp-util@^3.0.0, gulp-util@^3.0.4, gulp-util@^3.0.6, gulp-util@~3.0.8:
3564+
gulp-util@^3.0.0, gulp-util@^3.0.6, gulp-util@~3.0.8:
35663565
version "3.0.8"
35673566
resolved "https://registry.yarnpkg.com/gulp-util/-/gulp-util-3.0.8.tgz#0054e1e744502e27c04c187c3ecc505dd54bbb4f"
35683567
integrity sha1-AFTh50RQLifATBh8PsxQXdVLu08=
@@ -6354,11 +6353,6 @@ pinkie@^2.0.0:
63546353
resolved "https://registry.yarnpkg.com/pinkie/-/pinkie-2.0.4.tgz#72556b80cfa0d48a974e80e77248e80ed4f7f870"
63556354
integrity sha1-clVrgM+g1IqXToDnckjoDtT3+HA=
63566355

6357-
pkginfo@^0.3.0:
6358-
version "0.3.1"
6359-
resolved "https://registry.yarnpkg.com/pkginfo/-/pkginfo-0.3.1.tgz#5b29f6a81f70717142e09e765bbeab97b4f81e21"
6360-
integrity sha1-Wyn2qB9wcXFC4J52W76rl7T4HiE=
6361-
63626356
plugin-error@^0.1.2:
63636357
version "0.1.2"
63646358
resolved "https://registry.yarnpkg.com/plugin-error/-/plugin-error-0.1.2.tgz#3b9bb3335ccf00f425e07437e19276967da47ace"
@@ -7804,11 +7798,6 @@ stream-counter@~0.2.0:
78047798
dependencies:
78057799
readable-stream "~1.1.8"
78067800

7807-
stream-equal@0.1.6:
7808-
version "0.1.6"
7809-
resolved "https://registry.yarnpkg.com/stream-equal/-/stream-equal-0.1.6.tgz#cc522fab38516012e4d4ee47513b147b72359019"
7810-
integrity sha1-zFIvqzhRYBLk1O5HUTsUe3I1kBk=
7811-
78127801
stream-to-array@~2.3.0:
78137802
version "2.3.0"
78147803
resolved "https://registry.yarnpkg.com/stream-to-array/-/stream-to-array-2.3.0.tgz#bbf6b39f5f43ec30bc71babcb37557acecf34353"
@@ -8027,7 +8016,7 @@ throttleit@~0.0.2:
80278016
resolved "https://registry.yarnpkg.com/throttleit/-/throttleit-0.0.2.tgz#cfedf88e60c00dd9697b61fdd2a8343a9b680eaf"
80288017
integrity sha1-z+34jmDADdlpe2H90qg0OptoDq8=
80298018

8030-
through2@^0.6.1, through2@^0.6.3:
8019+
through2@^0.6.1:
80318020
version "0.6.5"
80328021
resolved "https://registry.yarnpkg.com/through2/-/through2-0.6.5.tgz#41ab9c67b29d57209071410e1d7a7a968cd3ad48"
80338022
integrity sha1-QaucZ7KdVyCQcUEOHXp6lozTrUg=

0 commit comments

Comments
 (0)