Switch AtomicWriteState to enum class

Author: hasty

examples/thermostat/thermostat-common/include/atomic-write-manager.h

@@ -28,10 +28,10 @@ namespace app {
 namespace Clusters {
 namespace Thermostat {
 
-enum AtomicWriteState
+enum class AtomicWriteState
 {
-    kAtomicWriteState_Closed = 0,
-    kAtomicWriteState_Open,
+    Closed = 0,
+    Open,
 };
 
 class ThermostatAtomicWriteManager : public AtomicWriteManager
@@ -158,7 +158,7 @@ class ThermostatAtomicWriteManager : public AtomicWriteManager
 
     struct AtomicWriteSession
     {
-        AtomicWriteState state = kAtomicWriteState_Closed;
+        AtomicWriteState state = AtomicWriteState::Closed;
         ScopedNodeId nodeId    = ScopedNodeId();
         EndpointId endpointId  = kInvalidEndpointId;
     };

examples/thermostat/thermostat-common/src/atomic-write-manager.cpp

@@ -146,7 +146,7 @@ void ThermostatAtomicWriteManager::OnTimerExpired(EndpointId endpoint)
     {
 
         auto atomicWriteState = mAtomicWriteSessions[i];
-        if (atomicWriteState.state == kAtomicWriteState_Open && atomicWriteState.endpointId == endpoint)
+        if (atomicWriteState.state == AtomicWriteState::Open && atomicWriteState.endpointId == endpoint)
         {
             if (mDelegate != nullptr)
             {
@@ -185,7 +185,7 @@ bool ThermostatAtomicWriteManager::InWrite(const std::optional<AttributeId> attr
 
     if (ep < ArraySize(mAtomicWriteSessions))
     {
-        inAtomicWrite = mAtomicWriteSessions[ep].state == kAtomicWriteState_Open;
+        inAtomicWrite = mAtomicWriteSessions[ep].state == AtomicWriteState::Open;
     }
     return inAtomicWrite;
 }
@@ -352,7 +352,7 @@ bool ThermostatAtomicWriteManager::BeginWrite(chip::app::CommandHandler * comman
         DataModel::List<const AtomicAttributeStatusStruct::Type>(attributeStatuses.data(), attributeStatuses.size());
     if (status == Status::Success)
     {
-        SetWriteState(endpoint, GetSourceScopedNodeId(commandObj), kAtomicWriteState_Open);
+        SetWriteState(endpoint, GetSourceScopedNodeId(commandObj), AtomicWriteState::Open);
         timeout          = std::min(timeoutRequest, timeout);
         response.timeout = MakeOptional(timeout.count());
         ScheduleTimer(endpoint, timeout);
@@ -481,15 +481,15 @@ bool ThermostatAtomicWriteManager::RollbackWrite(chip::app::CommandHandler * com
 void ThermostatAtomicWriteManager::ResetWrite(EndpointId endpoint)
 {
     ClearTimer(endpoint);
-    SetWriteState(endpoint, ScopedNodeId(), kAtomicWriteState_Closed);
+    SetWriteState(endpoint, ScopedNodeId(), AtomicWriteState::Closed);
 }
 
 void ThermostatAtomicWriteManager::ResetWrite(FabricIndex fabricIndex)
 {
     for (size_t i = 0; i < ArraySize(mAtomicWriteSessions); ++i)
     {
         auto atomicWriteState = mAtomicWriteSessions[i];
-        if (atomicWriteState.state == kAtomicWriteState_Open && atomicWriteState.nodeId.GetFabricIndex() == fabricIndex)
+        if (atomicWriteState.state == AtomicWriteState::Open && atomicWriteState.nodeId.GetFabricIndex() == fabricIndex)
         {
             ResetWrite(atomicWriteState.endpointId);
         }