Apply suggestions from code review

Co-authored-by: Nivi Sarkar <55898241+nivi-apple@users.noreply.github.com>

Author: hasty

examples/thermostat/thermostat-common/include/atomic-write-manager.h

@@ -52,7 +52,7 @@ class ThermostatAtomicWriteManager : public AtomicWriteManager
      * @param attributeId Optional attribute filter
      * @param endpoint The endpoint to check atomic write state
      * @return true if there is an open atomic write
-     * @return false if there is not at open atomic write
+     * @return false if there is no open atomic write
      */
     bool InWrite(const std::optional<AttributeId> attributeId, EndpointId endpoint) override;
 
@@ -64,7 +64,7 @@ class ThermostatAtomicWriteManager : public AtomicWriteManager
      * @param subjectDescriptor The subject descriptor to check against
      * @param endpoint The endpoint to check atomic write state
      * @return true if there is an open atomic write
-     * @return false if there is not an open atomic write
+     * @return false if there is no open atomic write
      */
     bool InWrite(const std::optional<AttributeId> attributeId, const Access::SubjectDescriptor & subjectDescriptor,
                  EndpointId endpoint) override;
@@ -76,8 +76,8 @@ class ThermostatAtomicWriteManager : public AtomicWriteManager
      * @param attributeId
      * @param commandObj
      * @param endpoint
-     * @return true
-     * @return false
+     * @return true if there is an open atomic write
+     * @return false if there is no open atomic write
      */
     bool InWrite(const std::optional<AttributeId> attributeId, CommandHandler * commandObj, EndpointId endpoint) override;
 
@@ -89,7 +89,7 @@ class ThermostatAtomicWriteManager : public AtomicWriteManager
      * @param commandObj The command being invoked
      * @param endpoint The endpoint for the atomic write
      * @return true if there is an open atomic write
-     * @return false if there is not an open atomic write
+     * @return false if there is no open atomic write
      */
     bool InWrite(const DataModel::DecodableList<AttributeId>::Iterator attributeIds, CommandHandler * commandObj,
                  EndpointId endpoint) override;
@@ -100,27 +100,27 @@ class ThermostatAtomicWriteManager : public AtomicWriteManager
      * @param commandObj The AtomicRequest command
      * @param commandPath The path for the command
      * @param commandData The payload of the command
-     * @return true if the atomic write was opened
-     * @return false if the atomic write was not opened
+     * @return true if the atomic write was opened successfully
+     * @return false if the request to open atomic write failed
      */
     bool BeginWrite(chip::app::CommandHandler * commandObj, const ConcreteCommandPath & commandPath,
                     const Commands::AtomicRequest::DecodableType & commandData) override;
 
     /**
-     * @brief Attempt to commit an atomic write; returns true if the server is able to commit or failed trying, false if it was
-     * unable to find a matching atomic write
+     * @brief Attempt to commit an atomic write; returns true if the server is able to either commit or rollback successfully,
+     * returns false otherwise
      *
      * @param commandObj The AtomicRequest command
      * @param commandPath The path for the command
      * @param commandData The payload of the command
-     * @return true if the atomic write was committed or rolled back
+     * @return true if the atomic write was either committed or rolled back
      * @return false if the atomic write was not found
      */
     bool CommitWrite(chip::app::CommandHandler * commandObj, const ConcreteCommandPath & commandPath,
                      const Commands::AtomicRequest::DecodableType & commandData) override;
 
     /**
-     * @brief Attempt to roll back an atomic write; returns true if the server is able to commit or failed trying, false if it was
+     * @brief Attempt to roll back an atomic write; returns true if the server is able to rollback successfully, false if it was
      * unable to find a matching atomic write
      *
      * @param commandObj The AtomicRequest command

examples/thermostat/thermostat-common/include/thermostat-delegate-impl.h

@@ -27,7 +27,7 @@ namespace Clusters {
 namespace Thermostat {
 
 /**
- * The ThermostatManager class serves as the instance delegate for storing Presets related information and providing it to the
+ * The ThermostatDelegate class serves as the instance delegate for storing Presets related information and providing it to the
  * Thermostat server code. It also manages the presets attribute and provides methods to write to presets, edit presets, maintain a
  * pending presets list and either commit the presets when requested or discard the changes. It also provides APIs to get and set
  * the attribute values.