Skip to content

Commit c1e5d29

Browse files
committed
Use Globals.Enums.AtomicRequestTypeEnum instead of hard coded values in TC_TSTAT_4_2
1 parent 83dc1c8 commit c1e5d29

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/python_testing/TC_TSTAT_4_2.py

+4-3
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
import logging
3131

3232
import chip.clusters as Clusters
33+
from chip.clusters import Globals
3334
from chip.clusters.Types import NullValue
3435
from chip.interaction_model import InteractionModelError, Status
3536
from matter_testing_support import MatterBaseTest, TestStep, async_test_body, default_matter_test_main
@@ -65,7 +66,7 @@ async def send_edit_atomic_request_begin_command(self,
6566
endpoint: int = None,
6667
expected_status: Status = Status.Success):
6768
try:
68-
await self.send_single_cmd(cmd=cluster.Commands.AtomicRequest(requestType=0,
69+
await self.send_single_cmd(cmd=cluster.Commands.AtomicRequest(requestType=Globals.Enums.AtomicRequestTypeEnum.kBeginWrite,
6970
attributeRequests=[
7071
cluster.Attributes.Presets.attribute_id],
7172
timeout=1800),
@@ -81,7 +82,7 @@ async def send_edit_atomic_request_commit_command(self,
8182
expected_overall_status: Status = Status.Success,
8283
expected_preset_status: Status = Status.Success):
8384
try:
84-
response = await self.send_single_cmd(cmd=cluster.Commands.AtomicRequest(requestType=1,
85+
response = await self.send_single_cmd(cmd=cluster.Commands.AtomicRequest(requestType=Globals.Enums.AtomicRequestTypeEnum.kCommitWrite,
8586
attributeRequests=[cluster.Attributes.Presets.attribute_id, cluster.Attributes.Schedules.attribute_id]),
8687
endpoint=endpoint)
8788
asserts.assert_equal(expected_status, Status.Success, "We expected we had a valid commit command")
@@ -100,7 +101,7 @@ async def send_edit_atomic_request_rollback_command(self,
100101
endpoint: int = None,
101102
expected_status: Status = Status.Success):
102103
try:
103-
await self.send_single_cmd(cmd=cluster.Commands.AtomicRequest(requestType=2,
104+
await self.send_single_cmd(cmd=cluster.Commands.AtomicRequest(requestType=Globals.Enums.AtomicRequestTypeEnum.kRollbackWrite,
104105
attributeRequests=[cluster.Attributes.Presets.attribute_id, cluster.Attributes.Schedules.attribute_id]),
105106
endpoint=endpoint)
106107
asserts.assert_equal(expected_status, Status.Success)

0 commit comments

Comments
 (0)