Skip to content

Commit db9f2ed

Browse files
Bump third_party/pigweed/repo from 9e4bfb9 to e765c4d (project-chip#29314)
* Bump third_party/pigweed/repo from `9e4bfb9` to `e765c4d` Bumps [third_party/pigweed/repo](https://github.com/google/pigweed) from `9e4bfb9` to `e765c4d`. - [Commits](google/pigweed@9e4bfb9...e765c4d) --- updated-dependencies: - dependency-name: third_party/pigweed/repo dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Make gdbus compilation not fail on unreachable code * Restyle * Skip clang-tidy on java codegen files since it is very slow (lots of templates) and it is generated code without actual changes in general * Skip the new missing default case bugprone as too many hits currently * Remove one more bugprone check - very hard to meet with templates and char** to void* conversions * Exclude one more bugprone: it is complaining about valid code in TestReportingEngine and I could find no way to actually fix it * Fix regex for exclusion for clang-tidy * Fix some clang-tidy complains --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andrei Litvin <andy314@gmail.com>
1 parent 394eed3 commit db9f2ed

File tree

5 files changed

+18
-8
lines changed

5 files changed

+18
-8
lines changed

.clang-tidy

+4-1
Original file line numberDiff line numberDiff line change
@@ -10,20 +10,23 @@ Checks: >
1010
readability-redundant-control-flow,
1111
readability-redundant-string-cstr,
1212
readability-redundant-string-init,
13-
-bugprone-assignment-in-if-condition,
13+
-bugprone-assignment-in-if-condition,
1414
-bugprone-branch-clone,
1515
-bugprone-copy-constructor-init,
1616
-bugprone-easily-swappable-parameters,
1717
-bugprone-forward-declaration-namespace,
1818
-bugprone-forwarding-reference-overload,
1919
-bugprone-implicit-widening-of-multiplication-result,
20+
-bugprone-inc-dec-in-conditions,
2021
-bugprone-macro-parentheses,
2122
-bugprone-misplaced-widening-cast,
23+
-bugprone-multi-level-implicit-pointer-conversion,
2224
-bugprone-narrowing-conversions,
2325
-bugprone-not-null-terminated-result,
2426
-bugprone-reserved-identifier,
2527
-bugprone-signed-char-misuse,
2628
-bugprone-suspicious-include,
29+
-bugprone-switch-missing-default-case,
2730
-bugprone-undelegated-constructor,
2831
-bugprone-unused-return-value,
2932
-clang-analyzer-core.CallAndMessage,

.github/workflows/build.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ jobs:
200200
./scripts/run_in_build_env.sh \
201201
"./scripts/run-clang-tidy-on-compile-commands.py \
202202
--compile-database out/sanitizers/compile_commands.json \
203-
--file-exclude-regex '/(repo|zzz_generated|lwip/standalone)/' \
203+
--file-exclude-regex '/(repo|zzz_generated|lwip/standalone)/|-ReadImpl|-InvokeSubscribeImpl' \
204204
check \
205205
"
206206
- name: Clean output

build/chip/linux/gdbus_library.gni

+7
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,12 @@ template("gdbus_library") {
3535
include_dirs = [ "${root_gen_dir}/include" ]
3636
}
3737

38+
config("${library_name}_compile_config") {
39+
# dbus code generation may generate some code detected as unreacheable
40+
# by recent enough clang
41+
cflags = [ "-Wno-unreachable-code" ]
42+
}
43+
3844
dbus_sources = []
3945
foreach(xml, invoker.sources) {
4046
name = get_path_info(xml, "name")
@@ -94,6 +100,7 @@ template("gdbus_library") {
94100
sources = dbus_sources
95101
deps = [ ":${library_name}_gen" ]
96102

103+
configs += [ ":${library_name}_compile_config" ]
97104
public_configs = [
98105
":${library_name}_config",
99106
glib_config,

src/controller/java/AndroidDeviceControllerWrapper.cpp

+5-5
Original file line numberDiff line numberDiff line change
@@ -403,8 +403,8 @@ CHIP_ERROR AndroidDeviceControllerWrapper::ApplyNetworkCredentials(chip::Control
403403
passwordStr = static_cast<jstring>(env->NewGlobalRef(env->CallObjectMethod(wifiCredentialsJava, getPassword)));
404404
VerifyOrReturnError(ssidStr != nullptr && !env->ExceptionCheck(), CHIP_JNI_ERROR_EXCEPTION_THROWN);
405405

406-
ssid = env->GetStringUTFChars(ssidStr, 0);
407-
password = env->GetStringUTFChars(passwordStr, 0);
406+
ssid = env->GetStringUTFChars(ssidStr, nullptr);
407+
password = env->GetStringUTFChars(passwordStr, nullptr);
408408
jsize ssidLength = env->GetStringUTFLength(ssidStr);
409409
jsize passwordLength = env->GetStringUTFLength(passwordStr);
410410

@@ -601,7 +601,7 @@ void AndroidDeviceControllerWrapper::OnScanNetworksSuccess(
601601
std::string NetworkingStatusCtorSignature = "(I)V";
602602
jint jniNetworkingStatus = static_cast<jint>(dataResponse.networkingStatus);
603603
chip::JniReferences::GetInstance().CreateBoxedObject<jint>(
604-
NetworkingStatusClassName.c_str(), NetworkingStatusCtorSignature.c_str(), jniNetworkingStatus, NetworkingStatus);
604+
NetworkingStatusClassName, NetworkingStatusCtorSignature, jniNetworkingStatus, NetworkingStatus);
605605
jobject DebugText;
606606
if (!dataResponse.debugText.HasValue())
607607
{
@@ -633,8 +633,8 @@ void AndroidDeviceControllerWrapper::OnScanNetworksSuccess(
633633
std::string newElement_securityClassName = "java/lang/Integer";
634634
std::string newElement_securityCtorSignature = "(I)V";
635635
jint jniNewElementSecurity = static_cast<jint>(entry.security.Raw());
636-
chip::JniReferences::GetInstance().CreateBoxedObject<jint>(newElement_securityClassName.c_str(),
637-
newElement_securityCtorSignature.c_str(),
636+
chip::JniReferences::GetInstance().CreateBoxedObject<jint>(newElement_securityClassName,
637+
newElement_securityCtorSignature,
638638
jniNewElementSecurity, newElement_security);
639639
jobject newElement_ssid;
640640
jbyteArray newElement_ssidByteArray = env->NewByteArray(static_cast<jsize>(entry.ssid.size()));

third_party/pigweed/repo

Submodule repo updated 491 files

0 commit comments

Comments
 (0)