Skip to content

chore: Fix CI install rust toolchain #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamesmunns opened this issue Apr 25, 2025 · 0 comments
Open

chore: Fix CI install rust toolchain #528

jamesmunns opened this issue Apr 25, 2025 · 0 comments

Comments

@jamesmunns
Copy link
Collaborator

jamesmunns commented Apr 25, 2025

Also, incidentally, i think the current "install rust toolchain" step is wrong everywhere, since it's running before checkout and doesn't include the toolchain file. it will always show the default toolchain on the github actions runner, and not the toolchain in our rust-toolchain.toml...so it's basically pointless. And, furthermore, I think the recent Rustup changes to stop implicitly installing toolchains (rust-lang/rustup#3635) would have broken this if they weren't reverted (rust-lang/rustup#4211), since rustup show would no longer install the required toolchain if it's not present. So, we should probably change all the "install rust toolchain" steps by:

  • moving them after the checkout step, and
  • making them do rustup toolchain install rather than rustup show.

But, this should be done in a separate PR.

Originally posted by @hawkw in #526 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant