Fix contact_thresh_neg value for the lift #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lift contact_thresh_neg value is not respected when supplied with move_to, move_by command because for the lift a sane value for this argument would still be positive. However, in HelloController, the i_contact_neg value is always converted to a negative value by multiplying the absolute with -1. Hence, the guarded contact comparison for contact_thresh_neg always happens with a negative value at the controller level which for the lift is achieved only when a very high force is applied.
The fix in this PR gets rid of the extraneous operation with -1 as it’s not necessary if the user sets the contact_thresh_neg value with the correct sign.