Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider pkg-config for finding the compiler flags? #227

Open
dipterix opened this issue Jul 24, 2024 · 3 comments
Open

Consider pkg-config for finding the compiler flags? #227

dipterix opened this issue Jul 24, 2024 · 3 comments

Comments

@dipterix
Copy link

This issue is a continuation of #165

Background:

Recently homebrew has changed their HDF5 from using autoconf to cmake. The result is h5cc -show (used by configure.ac) is broken, causing hdf5r to crash during compiling.

Besides, HDF5Groups have a discussion of kicking autotools out and embrace cmake (https://www.hdfgroup.org/2022/11/can-we-remove-the-autotools/) in its new versions.

Currently if you are using Mac and install the newest HDF5, it's most likely that the HDF5 is configured with cmake and pkg-config is installed (brew list it as the dependence). In fact, Python package h5py uses pkgconfig to determine the flags too.

Maybe it's time to consider adding pkg-config as a back-up method in case h5cc -show results in error?

@hhoeflin
Copy link
Owner

hhoeflin commented Jul 24, 2024 via email

@dipterix
Copy link
Author

Let me see what I can do. I notice that there is no header file for 1.14.3 in inst folder. I wonder if that's OK?

@hhoeflin
Copy link
Owner

hhoeflin commented Jul 24, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants