Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sft阶段使用streaming dataset和do_predict时报错 #7571

Open
1 task done
xxchauncey opened this issue Apr 2, 2025 · 0 comments
Open
1 task done

sft阶段使用streaming dataset和do_predict时报错 #7571

xxchauncey opened this issue Apr 2, 2025 · 0 comments
Labels
bug Something isn't working pending This problem is yet to be addressed

Comments

@xxchauncey
Copy link

xxchauncey commented Apr 2, 2025 •
edited by hiyouga
Loading

Reminder

  • I have read the above rules and searched the existing issues.

Reproduction

当prediction结束时，在save_predictions中iterabledataset类无法直接访问input_ids（non-streaming dataset此处可正常访问），报错NotImplementedError: Subclasses of Dataset should implement __getitem__
https://github.com/hiyouga/LLaMA-Factory/blob/main/src/llamafactory/train/sft/trainer.py#L157
@xxchauncey xxchauncey added bug Something isn't working pending This problem is yet to be addressed labels Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working pending This problem is yet to be addressed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xxchauncey