Skip to content

Commit 6eb814e

Browse files
oidebrettMartinHjelmaremarcelveldt
authored
Fix open commissioning window tuple bug (#447)
Co-authored-by: Martin Hjelmare <marhje52@gmail.com> Co-authored-by: Marcel van der Veldt <m.vanderveldt@outlook.com>
1 parent 5b941cf commit 6eb814e

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

matter_server/server/device_controller.py

+3-4
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
import time
1212
from typing import TYPE_CHECKING, Any, Callable, Iterable, TypeVar, cast
1313

14-
from chip.ChipDeviceCtrl import CommissionableNode
14+
from chip.ChipDeviceCtrl import CommissionableNode, CommissioningParameters
1515
from chip.clusters import Attribute, Objects as Clusters
1616
from chip.clusters.Attribute import ValueDecodeFailure
1717
from chip.clusters.ClusterObjects import ALL_ATTRIBUTES, ALL_CLUSTERS, Cluster
@@ -273,7 +273,7 @@ async def open_commissioning_window(
273273
iteration: int = 1000,
274274
option: int = 1,
275275
discriminator: int | None = None,
276-
) -> tuple[int, str]:
276+
) -> CommissioningParameters:
277277
"""Open a commissioning window to commission a device present on this controller to another.
278278
279279
Returns code to use as discriminator.
@@ -284,15 +284,14 @@ async def open_commissioning_window(
284284
if discriminator is None:
285285
discriminator = 3840 # TODO generate random one
286286

287-
pin, code = await self._call_sdk(
287+
return await self._call_sdk(
288288
self.chip_controller.OpenCommissioningWindow,
289289
nodeid=node_id,
290290
timeout=timeout,
291291
iteration=iteration,
292292
discriminator=discriminator,
293293
option=option,
294294
)
295-
return pin, code
296295

297296
@api_command(APICommand.DISCOVER)
298297
async def discover_commissionable_nodes(

0 commit comments

Comments
 (0)