Skip to content

Commit 950663f

Browse files
authored
Edge case defect when importing the first test node into dashboard (#763)
1 parent ffaf1f7 commit 950663f

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

matter_server/server/device_controller.py

+6-1
Original file line numberDiff line numberDiff line change
@@ -865,7 +865,12 @@ async def import_test_node(self, dump: str) -> None:
865865
else:
866866
dump_nodes = dump_data["data"]["server"]["nodes"]
867867
# node ids > 900000 are reserved for test nodes
868-
next_test_node_id = max(*(x for x in self._nodes), TEST_NODE_START) + 1
868+
if self._nodes:
869+
next_test_node_id = max(*(x for x in self._nodes), TEST_NODE_START) + 1
870+
else:
871+
# an empty self._nodes dict evaluates to false so we set the first
872+
# test node id to TEST_NODE_START
873+
next_test_node_id = TEST_NODE_START
869874
for node_dict in dump_nodes:
870875
node = dataclass_from_dict(MatterNodeData, node_dict, strict=True)
871876
node.node_id = next_test_node_id

0 commit comments

Comments
 (0)