Raise update error if the node moves from querying to idle

When the node's UpdateStateEnum changes from Querying to Idle it
means the update file did not get processed. This could be due to
temporary network issues or the update file not being honored by the
target node.

Author: agners

matter_server/server/ota/provider.py

@@ -353,11 +353,21 @@ async def check_update_state(
             Clusters.OtaSoftwareUpdateRequestor.Enums.UpdateStateEnum, new_value
         )
 
+        old_update_state = cast(
+            Clusters.OtaSoftwareUpdateRequestor.Enums.UpdateStateEnum, old_value
+        )
+
         # Update state of target node changed, check if update is done.
         if (
             update_state
             == Clusters.OtaSoftwareUpdateRequestor.Enums.UpdateStateEnum.kIdle
         ):
+            if (
+                old_update_state
+                == Clusters.OtaSoftwareUpdateRequestor.Enums.UpdateStateEnum.kQuerying
+            ):
+                raise UpdateError("Target node did not process the update file")
+
             LOGGER.info(
                 "Node %d update state idle, assuming done.", self._ota_target_node_id
             )