Skip to content

Commit d5a32f0

Browse files
committed
just re-raise unhandled exceptions
1 parent b248f28 commit d5a32f0

File tree

1 file changed

+4
-10
lines changed

1 file changed

+4
-10
lines changed

matter_server/server/client_handler.py

+4-10
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
from matter_server.common.helpers.json import json_dumps, json_loads
1616
from matter_server.common.models import EventType
1717

18-
from ..common.errors import InvalidArguments, InvalidCommand, MatterError, SDKStackError
18+
from ..common.errors import InvalidArguments, InvalidCommand, MatterError
1919
from ..common.helpers.api import parse_arguments
2020
from ..common.helpers.util import dataclass_from_dict
2121
from ..common.models import (
@@ -204,16 +204,10 @@ async def _run_handler(
204204
# only print the full stacktrace if debug logging is enabled
205205
exc_info=err if self._logger.isEnabledFor(logging.DEBUG) else None,
206206
)
207-
self._send_message(
208-
ErrorResultMessage(msg.message_id, SDKStackError.error_code, str(err))
209-
)
210-
except Exception as err: # pylint: disable=broad-except
211-
self._logger.exception(
212-
"Unhandled exception while handling: %s",
213-
msg.command,
214-
)
215-
error_code = getattr(err, "error_code", 0)
216207
self._send_message(ErrorResultMessage(msg.message_id, error_code, str(err)))
208+
except Exception as err:
209+
self._send_message(ErrorResultMessage(msg.message_id, 0, str(err)))
210+
raise err
217211

218212
async def _writer(self) -> None:
219213
"""Write outgoing messages."""

0 commit comments

Comments
 (0)