Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tankerkoenig Gas-Type selector during integration setup doesn't work #140820

Closed
ThemeIT opened this issue Mar 17, 2025 · 4 comments · Fixed by #141207
Closed

Tankerkoenig Gas-Type selector during integration setup doesn't work #140820

ThemeIT opened this issue Mar 17, 2025 · 4 comments · Fixed by #141207

Comments

@ThemeIT
Copy link

ThemeIT commented Mar 17, 2025

The problem

During setup of the Tankerkoenig Integration three checkboxes ask for what type of gas it should look for (see image 1). Even if only single gas-types are selected all entities will be generated and fetched (see image 3)

I would except the integration to only setup the entities for that gas-types that were marked in the checkboxes during integration setup.

Image 1
Image

Image 2
Image

Image 3
Image

What version of Home Assistant Core has the issue?

core-2025.3.3

What was the last working version of Home Assistant Core?

?

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Tankerkoenig

Link to integration documentation on our website

https://www.home-assistant.io/integrations/tankerkoenig/

Diagnostics information

No response

Example YAML snippet

Anything in the logs that might be useful for us?

Additional information

No response

@home-assistant
Copy link

Hey there @guillempages, @mib1185, @jpbede, mind taking a look at this issue as it has been labeled with an integration (tankerkoenig) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tankerkoenig can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign tankerkoenig Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


tankerkoenig documentation
tankerkoenig source
(message by IssueLinks)

@ThemeIT
Copy link
Author

ThemeIT commented Mar 17, 2025

Edit: on a second guess the checkboxes during setup could also be meant as "check for which gas type you want to search for on the API" which doesnt necessarily mean that only that gas-type entity will be created.

However even if that would be the case the checkboxes would not be handled properly as even checking nothing will return all gas
stations in a given range (also if you f.e. check for "Super" some Diesel-only Gas stations will still be returned.)

@mib1185
Copy link
Contributor

mib1185 commented Mar 21, 2025

Indeed, the fuel types are not considered anywhere in the integration ... it seems to be an regression of #108913
@jpbede was this intentional, that we've changed from for fuel in coordinator.fuel_types: to for fuel in (GasType.E10, GasType.E5, GasType.DIESEL): ?

@jpbede
Copy link
Member

jpbede commented Mar 21, 2025

No, I think was unintentional while refactoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants