Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_downloader is rather misleading.... #1

Open
2e0byo opened this issue Apr 20, 2022 · 2 comments
Open

test_downloader is rather misleading.... #1

2e0byo opened this issue Apr 20, 2022 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@2e0byo
Copy link

2e0byo commented Apr 20, 2022

Currently test_downloader contains one placeholder test:

def test_download():
    assert True

It might be better to remove this file entirely, or at any rate to remove the defunct test in it... though I guess it does test that the testsuite is set up properly!

@hrishikeshrt
Copy link
Owner

More than "testing that test suit is set up properly", it is sort of a pinch that "need to write tests"!
I'd be happy to accept pull requests in case you are willing to submit one.

@2e0byo
Copy link
Author

2e0byo commented Apr 20, 2022

I'll PR some in a bit. Forked to fix an issue you've already fixed (handling servers which don't give a content_length); poetry had pulled in an old version. But now I have a fork, so it should be put to some work. Thanks for the library, btw :)

@hrishikeshrt hrishikeshrt added enhancement New feature or request help wanted Extra attention is needed labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants