Skip to content

Commit 5452767

Browse files
toktarryjones
toktar
authored andcommitted
up-41: add schema tests
Signed-off-by: toktar <renata.toktar@evernym.com>
1 parent 759a6c1 commit 5452767

File tree

4 files changed

+65
-6
lines changed

4 files changed

+65
-6
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
from collections import OrderedDict
2+
3+
from indy_common.types import ClientGetFeeOperation
4+
from plenum.common.messages.fields import ConstantField, LimitedLengthStringField
5+
6+
EXPECTED_ORDERED_FIELDS = OrderedDict([
7+
("type", ConstantField),
8+
("alias", LimitedLengthStringField),
9+
])
10+
11+
12+
def test_has_expected_fields():
13+
actual_field_names = OrderedDict(ClientGetFeeOperation.schema).keys()
14+
assert actual_field_names == EXPECTED_ORDERED_FIELDS.keys()
15+
16+
17+
def test_has_expected_validators():
18+
schema = dict(ClientGetFeeOperation.schema)
19+
for field, validator in EXPECTED_ORDERED_FIELDS.items():
20+
assert isinstance(schema[field], validator)
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
from collections import OrderedDict
2+
3+
from indy_common.types import ClientGetFeesOperation
4+
from plenum.common.messages.fields import ConstantField
5+
6+
EXPECTED_ORDERED_FIELDS = OrderedDict([
7+
("type", ConstantField),
8+
])
9+
10+
11+
def test_has_expected_fields():
12+
actual_field_names = OrderedDict(ClientGetFeesOperation.schema).keys()
13+
assert actual_field_names == EXPECTED_ORDERED_FIELDS.keys()
14+
15+
16+
def test_has_expected_validators():
17+
schema = dict(ClientGetFeesOperation.schema)
18+
for field, validator in EXPECTED_ORDERED_FIELDS.items():
19+
assert isinstance(schema[field], validator)
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
from collections import OrderedDict
2+
3+
from indy_common.types import ClientSetFeesOperation, SetFeesField
4+
from plenum.common.messages.fields import ConstantField
5+
6+
EXPECTED_ORDERED_FIELDS = OrderedDict([
7+
("type", ConstantField),
8+
("fees", SetFeesField),
9+
])
10+
11+
12+
def test_has_expected_fields():
13+
actual_field_names = OrderedDict(ClientSetFeesOperation.schema).keys()
14+
assert actual_field_names == EXPECTED_ORDERED_FIELDS.keys()
15+
16+
17+
def test_has_expected_validators():
18+
schema = dict(ClientSetFeesOperation.schema)
19+
for field, validator in EXPECTED_ORDERED_FIELDS.items():
20+
assert isinstance(schema[field], validator)

indy_common/types.py

+6-6
Original file line numberDiff line numberDiff line change
@@ -467,14 +467,14 @@ class ClientGetRichSchemaObjectByMetadataOperation(MessageValidator):
467467
)
468468

469469

470-
class ClientGetFeeMsgOperation(MessageValidator):
470+
class ClientGetFeeOperation(MessageValidator):
471471
schema = (
472472
(TXN_TYPE, ConstantField(GET_FEE)),
473473
(FEES_ALIAS, LimitedLengthStringField(max_length=FEE_ALIAS_LENGTH)),
474474
)
475475

476476

477-
class ClientGetFeesMsgOperation(MessageValidator):
477+
class ClientGetFeesOperation(MessageValidator):
478478
schema = (
479479
(TXN_TYPE, ConstantField(GET_FEES)),
480480
)
@@ -491,7 +491,7 @@ def _specific_validation(self, val):
491491
return "set_fees -- " + error
492492

493493

494-
class ClientSetFeesMsgOperation(MessageValidator):
494+
class ClientSetFeesOperation(MessageValidator):
495495
schema = (
496496
(TXN_TYPE, ConstantField(SET_FEES)),
497497
(FEES, SetFeesField()),
@@ -528,9 +528,9 @@ class ClientOperationField(PClientOperationField):
528528
RICH_SCHEMA_PRES_DEF: ClientRichSchemaPresDefOperation(),
529529
GET_RICH_SCHEMA_OBJECT_BY_ID: ClientGetRichSchemaObjectByIdOperation(),
530530
GET_RICH_SCHEMA_OBJECT_BY_METADATA: ClientGetRichSchemaObjectByMetadataOperation(),
531-
GET_FEE: ClientGetFeeMsgOperation(),
532-
GET_FEES: ClientGetFeesMsgOperation(),
533-
SET_FEES: ClientSetFeesMsgOperation(),
531+
GET_FEE: ClientGetFeeOperation(),
532+
GET_FEES: ClientGetFeesOperation(),
533+
SET_FEES: ClientSetFeesOperation(),
534534
}
535535

536536
# TODO: it is a workaround because INDY-338, `operations` must be a class

0 commit comments

Comments
 (0)