Skip to content

Commit 465fadb

Browse files
authored
Merge pull request #224 from markpbaggett/issue-191
Attempt to address Issue-191.
2 parents e1663e5 + 655e706 commit 465fadb

File tree

3 files changed

+22
-10
lines changed

3 files changed

+22
-10
lines changed

iiif_prezi3/helpers/auto_fields.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22

33
from ..config.config import Config, register_config
44
from ..skeleton import (AnnotationPage, Canvas, Class, HomepageItem,
5-
KeyValueString, NavPlace, ProviderItem, Range,
6-
Reference, ResourceItem, ServiceItem1)
5+
KeyValueString, ManifestRef, NavPlace, ProviderItem,
6+
Range, Reference, ResourceItem, ServiceItem1)
77

88

99
class AutoConfig(Config):
@@ -179,8 +179,8 @@ def __init__(self):
179179
alst = AutoList(alstcfg, name="General")
180180
allst = AutoList(allstcfg, name="Language")
181181
# Set up some obvious defaults
182-
ai.register_on_class(AnnotationPage, Class)
183-
al.register_on_class(KeyValueString, Class, Reference, ResourceItem)
182+
ai.register_on_class(AnnotationPage, Class, ManifestRef)
183+
al.register_on_class(KeyValueString, Class, Reference, ResourceItem, ManifestRef)
184184
ait.register_on_class(Canvas, Range, AnnotationPage)
185185
alst.register_on_class(Class, AnnotationPage, ResourceItem, ServiceItem1, NavPlace, Reference, ProviderItem)
186186
allst.register_on_class(HomepageItem)

iiif_prezi3/helpers/make_manifest.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
11
from ..loader import monkeypatch_schema
2-
from ..skeleton import Collection, Manifest
2+
from ..skeleton import Collection, ManifestRef
33

44

55
class MakeManifest:
66

77
def make_manifest(self, **kwargs):
8-
"""Add a Manifest to a Collection.
8+
"""Add a Manifest to a Collection as a ManifestRef.
99
1010
Creates a new Manifest, adds a Reference to it to the
1111
calling Collection items and returns the newly created Manifest.
1212
Accepts keyword arguments to customize the resulting instance.
1313
"""
14-
manifest = Manifest(**kwargs)
14+
manifest = ManifestRef(**kwargs)
1515
self.add_item(manifest)
16-
return manifest
1716

17+
return manifest
1818

1919
monkeypatch_schema(Collection, MakeManifest)

tests/test_make_manifest.py

+14-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import unittest
22

3-
from iiif_prezi3 import Collection, Reference
3+
from iiif_prezi3 import Collection, HomepageItem, Reference, config
44

55

66
class MakeManifestTest(unittest.TestCase):
@@ -9,9 +9,21 @@ def setUp(self):
99
self.collection = Collection()
1010

1111
def test_make_manifest(self):
12+
config.configs['helpers.auto_fields.AutoLang'].auto_lang = "en"
13+
homepage = HomepageItem(
14+
id="https://www.getty.edu/art/collection/object/103RQQ",
15+
type="Text",
16+
label="Home page at the Getty Museum Collection",
17+
format="text/html",
18+
language=["en"]
19+
)
1220
manifest = self.collection.make_manifest(
13-
label={'en': ['default label']})
21+
id='http://example.org/iiif/1',
22+
label='default label',
23+
homepage=homepage,
24+
)
1425
self.assertEqual(len(self.collection.items), 1)
1526
self.assertIsInstance(self.collection.items[0], Reference)
1627
self.assertEqual(manifest.label,
1728
{'en': ['default label']})
29+
self.assertEqual(manifest.homepage, homepage)

0 commit comments

Comments
 (0)