Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename get_cam_op() to camtrapR_cameraOperation() #239

Closed
peterdesmet opened this issue Jul 14, 2023 · 1 comment · Fixed by #331
Closed

Rename get_cam_op() to camtrapR_cameraOperation() #239

peterdesmet opened this issue Jul 14, 2023 · 1 comment · Fixed by #331
Assignees
@damianooldoni
Milestone
v1.0

Comments

@peterdesmet
Copy link
Member

Suggested in camtraptor July 2023 coding sprint

Rationale: get functions are mixed bag, now same name as in camtrapR without masking. Some parameters should be removed as well.

camtrapR_cameraOperation(
  package = NULL,
  # ... removed, see filter functions
  station_col = "locationName",
  use_prefix = FALSE
  # datapkg removed
)
@peterdesmet peterdesmet added this to the v1.0 milestone Jul 14, 2023
damianooldoni added a commit that referenced this issue Jul 22, 2024
@damianooldoni
Rename get_cam_op()
7e44fd2 
See #239
@damianooldoni damianooldoni self-assigned this Jul 22, 2024
damianooldoni added a commit that referenced this issue Jul 22, 2024
@damianooldoni
Add renaming in NEWS.md
769dad4 
#239, #231, #240, #243
@damianooldoni damianooldoni mentioned this issue Jul 25, 2024
Merged
@sannegovaert sannegovaert linked a pull request Aug 1, 2024 that will close this issue
Use filter functions/remove args from functions #331
Merged
@damianooldoni
Copy link
Member

Fixed by PR #331.

@damianooldoni damianooldoni mentioned this issue Oct 30, 2024
Open
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damianooldoni damianooldoni

Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

Use filter functions/remove args from functions inbo/camtraptor
2 participants
@peterdesmet @damianooldoni