Skip to content

Commit efd09d4

Browse files
committedFeb 6, 2025
Rename finalize method for ping Healthcheck
It seems like the function in the Healthcheck class was renamed from finalize_result() to finalize() at some point, but was forgotten on the Healthcheck_ping class. This caused ping health checks to never timeout when the host was failing, causing the hosts to never be claimed as down.
1 parent 25e7d5b commit efd09d4

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed
 

‎src/healthcheck_ping.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ void Healthcheck_ping::callback(evutil_socket_t socket_fd, short what,
289289
///
290290
/// Due to lack of possibility to use typical libevent timeout mechanism on raw
291291
/// sockets, it is necessary to check timeout of this healthcheck manually.
292-
void Healthcheck_ping::finalize_result() {
292+
void Healthcheck_ping::finalize() {
293293
struct timespec now;
294294
string message;
295295

‎src/healthcheck_ping.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ class Healthcheck_ping : public Healthcheck {
5858
int schedule_healthcheck(struct timespec *now);
5959
static int initialize();
6060
static void destroy();
61-
void finalize_result();
61+
void finalize();
6262

6363
protected:
6464
void end_check(HealthcheckResult result, string message);

0 commit comments

Comments
 (0)