Skip to content

Commit 7d52f33

Browse files
committed
refactor: more defensive coding when getting external name for items
1 parent d7e6e2f commit 7d52f33

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

cls/SourceControl/Git/Utils.cls

+5-3
Original file line numberDiff line numberDiff line change
@@ -1251,9 +1251,12 @@ ClassMethod IsInSourceControl(InternalName As %String, ByRef sourceControlItem A
12511251
quit isInSourceControl
12521252
}
12531253

1254-
ClassMethod FullExternalName(ByRef InternalName As %String, ByRef MappingExists As %Boolean) As %String [ CodeMode = expression ]
1254+
ClassMethod FullExternalName(ByRef InternalName As %String, ByRef MappingExists As %Boolean) As %String
12551255
{
1256-
..TempFolder()_..ExternalName(.InternalName, .MappingExists)
1256+
set externalName = ..ExternalName(.InternalName, .MappingExists)
1257+
return $select(
1258+
externalName="":"",
1259+
1: ..TempFolder()_externalName)
12571260
}
12581261

12591262
ClassMethod NormalizeInternalName(ByRef name As %String, Output fromWebApp As %Boolean = 0, Output cspFilename) As %String
@@ -3198,4 +3201,3 @@ ClassMethod IsSchemaStandard(pName As %String = "") As %Boolean [ Internal ]
31983201
}
31993202

32003203
}
3201-

0 commit comments

Comments
 (0)