Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.10.x info command #755

Merged
merged 6 commits into from
Mar 14, 2025
Merged

V0.10.x info command #755

merged 6 commits into from
Mar 14, 2025

Conversation

isc-shuliu
Copy link
Collaborator

This PR adds an info command per #689 . It lists top level packages and their external name (if existent) and the semver without the build part. If a -verbose/-v modifier is passed, it will include default name in parentheses.

image

Copy link
Contributor

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going back to the spec in #689 there are a few more pieces than have been addressed here:

zpm "info" and zpm "info -verbose" are "get my bearings" and "answer all of Support's preliminary questions" use cases, respectively.

  • Display names of top-level packages (not dependencies) in the namespace are part of the base command, verbose variant shows External Name (internal-name) as relevant.
  • The IPM shell welcome text will call "info"
  • In "info -verbose" and put internal name in parentheses after external name
  • In "list-installed" put internal name in parentheses after external name

For "answer all of Supports' preliminary questions I think we will want the build in the -verbose mode.

Please confirm: @isc-kiyer @isc-eneil @isc-jili

@isc-shuliu
Copy link
Collaborator Author

isc-shuliu commented Mar 11, 2025

@isc-tleavitt
My concern is the info command can be very long when users install many packages, since each package takes a row. It may be longer than the height of the terminal screen and can clutter the terminal when user runs zpm. Are we sure this won't impact UX?

  • The IPM shell welcome text will call "info"

@isc-tleavitt
Copy link
Contributor

@isc-tleavitt My concern is the info command can be very long when users install many packages, since each package takes a row. It may be longer than the height of the terminal screen and can clutter the terminal when user runs zpm. Are we sure this won't impact UX?

  • The IPM shell welcome text will call "info"

Good point - let's flip this around: zpm "info" should also show the information in the shell welcome text (version, etc.) as a one-stop shop for everything Support would need.

@isc-shuliu isc-shuliu requested a review from isc-tleavitt March 11, 2025 15:18
@isc-shuliu
Copy link
Collaborator Author

@isc-tleavitt
This is the updated behavior.
Google Chrome 2025-03-13 12 15 08

@isc-tleavitt isc-tleavitt merged commit 7fefd07 into v0.10.x Mar 14, 2025
15 checks passed
@isc-tleavitt isc-tleavitt deleted the v0.10.x-info-command branch March 14, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPM shell banner rework and "info" command
3 participants