V0.10.x fix oras deployed code #754
Conversation
From working session/1:1 with @isc-shuliu
isc-shuliu
requested review from
isc-kiyer,
isc-tleavitt,
isc-eneil and
isc-etamarch
There was a problem hiding this comment.
@isc-shuliu Looks good but a few comments and action items. Also, general q: for listing modules in a repo + being able to install them, what is the defined behavior? I can think of the following cases:
- Module exists in non-deployed mode: in this case, no special handling since it can be installed on any system
- Module exists in deployed mode for version v1 and v2 and user is on v1 or v2: I think list-modules should display the versions for each platform available in list-modules but when the user tries to install, it picks the version they are on and installs the module. Perhaps could grey out or have an additional flag to list modules that are available in the repo but not installable on the current platform? By default I agree a user shouldn't be able to see module versions built for other platforms.
- Module exists in deployed mode for version v1 and v2 and user is on v3: based on the above, a user would fail to install the module but would be worthwhile them getting a better error message indicating the module exists in the repo but is incompatible with their platform version and offering them a command to view all platform versions available a module (some variation of list-modules)
There was a problem hiding this comment.
@isc-shuliu I have a few comments too; thank you for your work on this!
I do think it would be worth looking into PlatformVersion vs. PlatformVersions a bit more to see if we should just be using one of them.
Opened a separate issue for this. For now, |
| Set sorter(+semver.Major, +semver.Minor, +semver.Patch, " "_semver.Prerelease, " "_semver.Build) = version | ||
| } | ||
|
|
||
| Set major = "" |
There was a problem hiding this comment.
This is a great use case for $query but don't need to do that right now.
With this PR, deployed items are bundled into a %StudioProject for installing and uninstalling.
This PR also makes ORAS registries compatible with deployed items.