Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle ipfs.files.stat RPC error responses #2327

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: handle ipfs.files.stat RPC error responses #2327

wants to merge 4 commits into from

Conversation

Winter-Soren
Copy link

Fixes #2299

  • Added error handling for ipfs.files.stat when it returns Type: error
  • Shows error notification to user
  • Maintains UI functionality with fallback data

@Winter-Soren Winter-Soren requested a review from a team as a code owner February 9, 2025 12:52
@welcome Welcome
Copy link

welcome bot commented Feb 9, 2025

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines
    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@Winter-Soren
Copy link
Author

@lidel Can you review the PR and suggest any changes if needed, and guide me if I'm heading in the right direction?

@lidel lidel mentioned this pull request Feb 20, 2025
Open
3 tasks
lidel
lidel requested changes Feb 20, 2025
View reviewed changes
Copy link
Member

@lidel lidel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am afraid this does not fix the problem from #2299. See repro steps in #2299 (comment). When I simulate them, local dev server started with npc ci && npm start produces:

image

And no toaster with error is displayed.

I think if ipfs.files.stat for / occurs, and error includes value of Tsize is too large we should not only display toaster notification, but extend error message with suggestion that user should restart their node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Files: ipfs.files.stat RPC call missing error handling
2 participants
@Winter-Soren @lidel