Skip to content

Commit b967175

Browse files
olszomalmtrojnar
authored andcommitted
RFC3161 section-4.3 comment
1 parent 157bb78 commit b967175

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

osslsigncode.c

+9-1
Original file line numberDiff line numberDiff line change
@@ -2734,7 +2734,15 @@ static int verify_timestamp(SIGNATURE *signature, GLOBAL_OPTIONS *options)
27342734
if (!store)
27352735
goto out;
27362736
if (load_file_lookup(store, options->tsa_cafile)) {
2737-
/* verify timestamp against the time of its creation */
2737+
/*
2738+
* The TSA signing key MUST be of a sufficient length to allow for a sufficiently
2739+
* long lifetime. Even if this is done, the key will have a finite lifetime.
2740+
* Thus, any token signed by the TSA SHOULD be time-stamped again or notarized
2741+
* at a later date to renew the trust that exists in the TSA's signature.
2742+
* https://datatracker.ietf.org/doc/html/rfc3161#section-4
2743+
* Signtool does not respect this RFC and neither we do.
2744+
* So verify timestamp against the time of its creation.
2745+
*/
27382746
if (!set_store_time(store, signature->time)) {
27392747
printf("Failed to set store time\n");
27402748
X509_STORE_free(store);

0 commit comments

Comments
 (0)