Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converter should not require local locale settings #64

Open
chad-earthscope opened this issue Nov 1, 2021 · 1 comment
Open

Converter should not require local locale settings #64

chad-earthscope opened this issue Nov 1, 2021 · 1 comment

Comments

@chad-earthscope
Copy link

The converter requires being executed in a locale of C (or en_US.UTF-8 seems to work also):
https://github.com/iris-edu/stationxml-seed-converter#system-language-requirments

This effects the conversion between two formats, the encodings of which the user has no control over. Since the formats are fixed to specific encoding and number usage it makes sense to treat them as such in the converter, whatever the caller's locale is should not matter.

P.S. For this converter, where a users locale makes sense would be on input, like command line parameters. But I don't see any that take numbers and text should be assumed to be UTF-8.

@chad-earthscope
Copy link
Author

As an example, experiences and wasted time reporting and diagnosing such as in #63 could be avoided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant