Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider not building CMake on distros with a newer version available #265

Open
SwooshyCueb opened this issue Dec 11, 2024 · 1 comment
Open
Assignees

Comments

@SwooshyCueb
Copy link
Member

As we move towards find_package for more and more dependencies, the complexity that would be introduced by implementing distro-specific packaging in our current externals build system (and the amount of work required to implement it) is reduced. From where I stand today, I'm still uncertain whether it will ever be worth the effort to implement this for most packages, given that we will eventually be moving away from this system anyway.

However, I believe CMake is an exception. At present, switching to distro-provided CMake for distros with a newer version available than what we provide would involve making significantly fewer cross-repository changes than any other package. Moreover, we already use distro-provided CMake for newer distros in a number of places. Let's consider omitting CMake from externals in these cases.

@SwooshyCueb SwooshyCueb self-assigned this Dec 11, 2024
@trel
Copy link
Member

trel commented Dec 11, 2024

Yes - this makes a lot of sense. We have not leaned on a new CMake feature/bugfix in quite some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants