Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate interpreter segfault TODO comment for Python 3.6 vs 3.11 #553

Open
korydraughn opened this issue May 7, 2024 · 7 comments
Open

Comments

@korydraughn
Copy link
Contributor

See comment in the following code.

@classmethod
def tearDownClass(cls):
# TODO: Skipping this will result in an interpreter seg fault for Py3.6 but not 3.11; why?
del cls.logins

This may apply to other tests (i.e. collection_test.py).

@korydraughn korydraughn changed the title Investigate interpreter segfault for Python 3.6 vs 3.11 Investigate interpreter segfault TODO comment for Python 3.6 vs 3.11 May 7, 2024
@alanking alanking added this to the 2.1.0 milestone May 7, 2024
@alanking
Copy link
Contributor

alanking commented Aug 1, 2024

FWIW, I would recommend dropping support for 3.6 as part of #480 as it has been EOL since the end of 2021 (https://devguide.python.org/versions/#unsupported-versions), and so we won't need to worry about this.

@trel
Copy link
Member

trel commented Aug 1, 2024

FWIW, I would recommend dropping support for 3.6 as part of #480 as it has been EOL since the end of 2021 (https://devguide.python.org/versions/#unsupported-versions), and so we won't need to worry about this.

Yes please. We currently advertise 3.4, 3.5, and 3.6. Let's drop all three for 2.1.0.

'Programming Language :: Python :: 3.4',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',

We'll keep 2.7 (and 3.7, also EOL) until we get to our 3.0.0 release.

@trel
Copy link
Member

trel commented Aug 1, 2024

Hmm, that matrix of dropping support might be confusing to users.

@trel
Copy link
Member

trel commented Aug 1, 2024

So perhaps we move this issue to 3.0.0 and take care of all EOL issues at once?

@alanking
Copy link
Contributor

alanking commented Aug 1, 2024

I was more thinking of dropping support in 3.0.0. If we drop support for anything that came after python 2.7, that would be kind of weird.

Yes, I think moving this to the 3.0.0 milestone makes sense.

@trel trel modified the milestones: 2.1.0, 3.0.0 Aug 1, 2024
@trel
Copy link
Member

trel commented Aug 1, 2024

3.0.0 - done.

@trel
Copy link
Member

trel commented Aug 22, 2024

We want to remove support for < Python 3.8 for PRC 3.0.0.

Aka, we'll support 3.8 and later.

@trel trel modified the milestones: 3.0.0, 3.1.0 Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants