Skip to content

Commit 486bae3

Browse files
committed
fix: emit 'skip' for external pipeline on failure
we do not want to block the ability to merge code due to a scm-engine failure
1 parent cb49713 commit 486bae3

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

pkg/scm/gitlab/client.go

+1-7
Original file line numberDiff line numberDiff line change
@@ -210,13 +210,7 @@ func (client *Client) Stop(ctx context.Context, evalError error) error {
210210
)
211211

212212
if evalError != nil {
213-
status = go_gitlab.Failed
214-
215-
// If the evaluation failed due to no config file, consider it a "skip" instead
216-
if strings.Contains(evalError.Error(), "404 Not Found") {
217-
status = go_gitlab.Skipped
218-
}
219-
213+
status = go_gitlab.Skipped
220214
message = evalError.Error()
221215
}
222216

0 commit comments

Comments
 (0)