less panic

Author: jippi

cmd/shared.go

@@ -40,15 +40,17 @@ func ProcessMR(ctx context.Context, cCtx *cli.Context, mr string) error {
 		return err
 	}
 
-	if evalContext == nil {
+	if evalContext == nil || !evalContext.IsValid() {
+		fmt.Println("Evaluating context is empty, does the Merge Request exists?")
+
 		return nil
 	}
 
 	fmt.Println("Evaluating context")
 
 	matches, err := cfg.Evaluate(evalContext)
 	if err != nil {
-		panic(err)
+		return err
 	}
 
 	// spew.Dump(matches)
@@ -60,15 +62,15 @@ func ProcessMR(ctx context.Context, cCtx *cli.Context, mr string) error {
 	fmt.Println("Sync labels")
 
 	if err := sync(ctx, client, remoteLabels, matches); err != nil {
-		panic(err)
+		return err
 	}
 
 	fmt.Println("Done!")
 
 	fmt.Println("Updating MR")
 
 	if err := apply(ctx, client, matches); err != nil {
-		panic(err)
+		return err
 	}
 
 	fmt.Println("Done!")

pkg/scm/gitlab/context.go

@@ -74,3 +74,7 @@ func NewContext(ctx context.Context, baseURL, token string) (*Context, error) {
 
 	return evalContext, nil
 }
+
+func (c *Context) IsValid() bool {
+	return c != nil
+}

pkg/scm/interfaces.go

@@ -21,6 +21,7 @@ type MergeRequestClient interface {
 }
 
 type EvalContext interface {
+	IsValid() bool
 	_isEvalContext()
 }