refactor: stdlib cleanup and simplification

Author: jippi

pkg/stdlib/functions.go

@@ -15,18 +15,9 @@ import (
 var FilepathDir = expr.Function(
 	"filepath_dir",
 	func(params ...any) (any, error) {
-		if len(params) != 1 {
-			return nil, NewInvalidNumberOfArgumentsError("filepath_dir", "", 1, len(params))
-		}
-
-		val, ok := params[0].(string)
-		if !ok {
-			return nil, NewInvalidArgumentTypeError("filepath_dir", "input must be string")
-		}
-
-		return filepath.Dir(val), nil
+		return filepath.Dir(params[0].(string)), nil //nolint:forcetypeassert
 	},
-	filepath.Dir,
+	filepath.Dir, // string => string
 )
 
 func UniqSlice[T cmp.Ordered](in []T) []T {
@@ -40,31 +31,25 @@ func UniqSlice[T cmp.Ordered](in []T) []T {
 var Uniq = expr.Function(
 	"uniq",
 	func(args ...any) (any, error) {
-		if len(args) != 1 {
-			return nil, NewInvalidNumberOfArgumentsError("uniq", "", 1, len(args))
-		}
-
-		arg := args[0]
-
-		switch val := arg.(type) {
+		switch elements := args[0].(type) {
 		case []any:
 			var result []string
 
-			for _, v := range val {
-				result = append(result, fmt.Sprintf("%s", v))
+			for _, element := range elements {
+				result = append(result, fmt.Sprintf("%s", element))
 			}
 
 			return UniqSlice(result), nil
 
 		case []string:
-			return UniqSlice(val), nil
+			return UniqSlice(elements), nil
 
 		default:
-			return nil, NewInvalidArgumentTypeError("uniq", fmt.Sprintf("invalid input, must be an array of [string] or [interface], got %T", arg))
+			return nil, NewInvalidArgumentTypeError("uniq", fmt.Sprintf("invalid input, must be an array of [string] or [interface], got %T", args[0]))
 		}
 	},
-	new(func([]string) []string),
-	new(func([]any) []string),
+	new(func([]string) []string), // []string -> []string
+	new(func([]any) []string),    // []any -> []string (when using map() that always return []any)
 )
 
 // Override built-in duration() function to provide support for additional periods
@@ -74,36 +59,16 @@ var Uniq = expr.Function(
 var Duration = expr.Function(
 	"duration",
 	func(args ...any) (any, error) {
-		if len(args) != 1 {
-			return nil, NewInvalidNumberOfArgumentsError("duration", "", 1, len(args))
-		}
-
-		val, ok := args[0].(string)
-		if !ok {
-			return nil, NewInvalidArgumentTypeError("duration", fmt.Sprintf("invalid input, must be a string, got %T", args[0]))
-		}
-
-		return str2duration.ParseDuration(val)
+		return str2duration.ParseDuration(args[0].(string)) //nolint:forcetypeassert
 	},
-	time.ParseDuration,
+	time.ParseDuration, // string => (time.Duration, error)
 )
 
 var LimitPathDepthTo = expr.Function(
 	"limit_path_depth_to",
 	func(args ...any) (any, error) {
-		if len(args) != 2 {
-			return nil, NewInvalidNumberOfArgumentsError("limit_path_depth_to", "", 2, len(args))
-		}
-
-		input, ok := args[0].(string)
-		if !ok {
-			return nil, NewInvalidArgumentTypeError("limit_path_depth_to", fmt.Sprintf("invalid input, first argument must be a 'string', got %T", args[0]))
-		}
-
-		length, ok := args[1].(int)
-		if !ok {
-			return nil, NewInvalidArgumentTypeError("limit_path_depth_to", fmt.Sprintf("invalid input, first argument must be an 'int', got %T", args[0]))
-		}
+		input := args[0].(string) //nolint:forcetypeassert
+		length := args[1].(int)   //nolint:forcetypeassert
 
 		chunks := strings.Split(input, "/")
 		if len(chunks) <= length {
@@ -112,5 +77,5 @@ var LimitPathDepthTo = expr.Function(
 
 		return strings.Join(chunks[0:length-1], "/"), nil // nosemgrep
 	},
-	new(func(string, int) string),
+	new(func(string, int) string), // (string, int) => string
 )