Use std_string instead of string_view

Author: jlatusek

.clang-tidy

@@ -30,7 +30,6 @@ Checks: >
   -bugprone-switch-missing-default-case,
   -bugprone-undelegated-constructor,
   -bugprone-unused-return-value,
-  -bugprone-suspicious-stringview-data-usage,
   -clang-analyzer-core.CallAndMessage,
   -clang-analyzer-core.NonNullParamChecker,
   -clang-analyzer-core.NullDereference,

src/credentials/attestation_verifier/TestDACRevocationDelegateImpl.cpp

@@ -50,7 +50,7 @@ CHIP_ERROR TestDACRevocationDelegateImpl::SetDeviceAttestationRevocationSetPath(
 void TestDACRevocationDelegateImpl::ClearDeviceAttestationRevocationSetPath()
 {
     // clear the string_view
-    mDeviceAttestationRevocationSetPath = mDeviceAttestationRevocationSetPath.substr(0, 0);
+    mDeviceAttestationRevocationSetPath.clear();
 }
 
 // This method parses the below JSON Scheme
@@ -69,10 +69,10 @@ void TestDACRevocationDelegateImpl::ClearDeviceAttestationRevocationSetPath()
 bool TestDACRevocationDelegateImpl::IsEntryInRevocationSet(const CharSpan & akidHexStr, const CharSpan & issuerNameBase64Str,
                                                            const CharSpan & serialNumberHexStr)
 {
-    std::ifstream file(mDeviceAttestationRevocationSetPath.data());
+    std::ifstream file(mDeviceAttestationRevocationSetPath.c_str());
     if (!file.is_open())
     {
-        ChipLogError(NotSpecified, "Failed to open file: %s", mDeviceAttestationRevocationSetPath.data());
+        ChipLogError(NotSpecified, "Failed to open file: %s", mDeviceAttestationRevocationSetPath.c_str());
         return false;
     }
 
@@ -188,19 +188,19 @@ void TestDACRevocationDelegateImpl::CheckForRevokedDACChain(
         onCompletion->mCall(onCompletion->mContext, info, attestationError);
     }
 
-    ChipLogDetail(NotSpecified, "Checking for revoked DAC in %s", mDeviceAttestationRevocationSetPath.data());
+    ChipLogDetail(NotSpecified, "Checking for revoked DAC in %s", mDeviceAttestationRevocationSetPath.c_str());
 
     if (IsCertificateRevoked(info.dacDerBuffer))
     {
-        ChipLogProgress(NotSpecified, "Found revoked DAC in %s", mDeviceAttestationRevocationSetPath.data());
+        ChipLogProgress(NotSpecified, "Found revoked DAC in %s", mDeviceAttestationRevocationSetPath.c_str());
         attestationError = AttestationVerificationResult::kDacRevoked;
     }
 
-    ChipLogDetail(NotSpecified, "Checking for revoked PAI in %s", mDeviceAttestationRevocationSetPath.data());
+    ChipLogDetail(NotSpecified, "Checking for revoked PAI in %s", mDeviceAttestationRevocationSetPath.c_str());
 
     if (IsCertificateRevoked(info.paiDerBuffer))
     {
-        ChipLogProgress(NotSpecified, "Found revoked PAI in %s", mDeviceAttestationRevocationSetPath.data());
+        ChipLogProgress(NotSpecified, "Found revoked PAI in %s", mDeviceAttestationRevocationSetPath.c_str());
 
         if (attestationError == AttestationVerificationResult::kDacRevoked)
         {

src/credentials/attestation_verifier/TestDACRevocationDelegateImpl.h

@@ -19,6 +19,7 @@
 
 #include <credentials/attestation_verifier/DeviceAttestationVerifier.h>
 #include <lib/support/Span.h>
+#include <string>
 #include <string_view>
 
 namespace chip {
@@ -58,7 +59,7 @@ class TestDACRevocationDelegateImpl : public DeviceAttestationRevocationDelegate
                                 const CharSpan & serialNumberHexStr);
     bool IsCertificateRevoked(const ByteSpan & certDer);
 
-    std::string_view mDeviceAttestationRevocationSetPath;
+    std::string mDeviceAttestationRevocationSetPath;
 };
 
 } // namespace Credentials