Apply suggestions from code review

Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>

Author: ogrisel

CHANGES.md

@@ -1,10 +1,10 @@
 ### 3.5.0 - in development
 
 - Avoid raising `DeprecationWarning` related to `os.fork` when running in a
-  natively multi-threaded process. (#435).
+  natively multi-threaded process. (#429).
 
 - Fix a crash when calling commands that access `stdin` via `subprocess.run` in
-  worker processes on POSIX systems. (#435).
+  worker processes on POSIX systems. (#429).
 
 - Automatically call `faulthandler.enable()` when starting loky worker
   processes to report more informative information (post-mortem Python

loky/backend/fork_exec.py

@@ -39,29 +39,29 @@ def fork_exec(cmd, keep_fds, env=None):
 
     try:
         return _posixsubprocess.fork_exec(
-            cmd,
-            cmd[0:1],
-            True,
-            keep_fds,
-            None,
-            encoded_env,
-            -1,
-            -1,
-            -1,
-            -1,
-            -1,
-            -1,
-            errpipe_read,
-            errpipe_write,
-            False,
-            False,
-            *pgid_to_set,
-            None,
-            None,
-            None,
-            -1,
-            None,
-            *allow_vfork,
+            cmd,  # args
+            cmd[0:1],  # executable_list
+            True,  # close_fds
+            keep_fds,  # pass_fds
+            None,  # cwd
+            encoded_env,  # env
+            -1,  # p2cread
+            -1,  # p2cwrite
+            -1,  # c2pread
+            -1,  # c2pwrite
+            -1,  # errread
+            -1,  # errwrite
+            errpipe_read,  # errpipe_read
+            errpipe_write,  # errpipe_write
+            False,  # restore_signal
+            False,  # call_setsid
+            *pgid_to_set,  # pgid_to_set
+            None,  # gid
+            None,  # extra_groups
+            None,  # uid
+            -1,  # child_umask
+            None,  # preexec_fn
+            *allow_vfork,  # extra flag if vfork is available
         )
     finally:
         os.close(errpipe_read)