Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't manually set configuration? #29

Open
fineless71 opened this issue Feb 7, 2025 · 3 comments
Open

Can't manually set configuration? #29

fineless71 opened this issue Feb 7, 2025 · 3 comments

Comments

@fineless71
Copy link

fineless71 commented Feb 7, 2025

I'm trying to rate an app and I see "Configuration detected" as bareAOSP and rooted, but I never let the app see my root (I use Magisk's built-in DenyList) so I want to switch it to non-root, but I can't do this?

@jonathanklee
Copy link
Owner

jonathanklee commented Feb 8, 2025

@fineless71 Being able to manually choose the configuration would be prone to errors. You're device is still considered rooted which is the most important. If the app is working in the non-root case, I guess another contributor who has a cleaner user configuration would make the expected evaluation.

@fineless71
Copy link
Author

I mean I didn't let the app I'm trying to rate see my root. And I don't get what you mean by it being error prone, since if I rated the app as-is, it would be incorrect and thus an error. With manual configuration I could make it correct. I still think it should auto detect the device but with an option for manual confuration if needed.

@jonathanklee
Copy link
Owner

@fineless71 Yes but before rating the app you noticed that your configuration was not ok, so you did not make the error.
The thing is most of users are not always as tech savvy as you and haven't installed Magisk as you did. I would like to keep it as simple as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants