Update DiagnosticLog UX (Download complete / failed)

joonhaengHeo · joonhaengHeo · commit 8a4894e68857 · 2024-11-29T16:31:02.000+09:00
diff --git a/examples/android/CHIPTool/app/src/main/java/com/google/chip/chiptool/clusterclient/DiagnosticLogFragment.kt b/examples/android/CHIPTool/app/src/main/java/com/google/chip/chiptool/clusterclient/DiagnosticLogFragment.kt
@@ -79,12 +79,14 @@ class DiagnosticLogFragment : Fragment() {
   inner class ChipDownloadLogCallback : DownloadLogCallback {
     override fun onError(fabricIndex: Int, nodeId: Long, errorCode: Long) {
       Log.d(TAG, "onError: $fabricIndex, ${nodeId.toULong()}, $errorCode")
+      showMessage("Downloading Failed")
       mDownloadFileOutputStream?.flush() ?: return
     }
 
     override fun onSuccess(fabricIndex: Int, nodeId: Long) {
       Log.d(TAG, "onSuccess: $fabricIndex, ${nodeId.toULong()}")
       mDownloadFileOutputStream?.flush() ?: return
+      showMessage("Downloading Completed")
       mDownloadFile?.let { showNotification(it) } ?: return
     }
 

Original file line number	Diff line number	Diff line change
`@@ -79,12 +79,14 @@ class DiagnosticLogFragment : Fragment() {`
`79`	`79`	`inner class ChipDownloadLogCallback : DownloadLogCallback {`
`80`	`80`	`override fun onError(fabricIndex: Int, nodeId: Long, errorCode: Long) {`
`81`	`81`	`Log.d(TAG, "onError: $fabricIndex, ${nodeId.toULong()}, $errorCode")`
	`82`	`+ showMessage("Downloading Failed")`
`82`	`83`	`mDownloadFileOutputStream?.flush() ?: return`
`83`	`84`	`}`
`84`	`85`
`85`	`86`	`override fun onSuccess(fabricIndex: Int, nodeId: Long) {`
`86`	`87`	`Log.d(TAG, "onSuccess: $fabricIndex, ${nodeId.toULong()}")`
`87`	`88`	`mDownloadFileOutputStream?.flush() ?: return`
	`89`	`+ showMessage("Downloading Completed")`
`88`	`90`	`mDownloadFile?.let { showNotification(it) } ?: return`
`89`	`91`	`}`
`90`	`92`