Remove dependency on src/lib/address_resolve from platform (project-chip#30617)

andy31415 · web-flow · commit 55ada8b9e7ba · 2023-11-22T22:19:28.000Z
* Remove dependency on src/lib/address_resolve from platform

* Restyle

* Fix quorvo
diff --git a/src/platform/Infineon/CYW30739/BUILD.gn b/src/platform/Infineon/CYW30739/BUILD.gn
@@ -83,14 +83,6 @@ static_library("CYW30739") {
       "ThreadStackManagerImpl.h",
     ]
 
-    # TODO: platform should NOT depend on default_address_resolve_config. This should
-    #       be removed. See https://github.com/project-chip/connectedhomeip/issues/30596
-    #
-    #       Currently this exists because OpenThread platform includes src/app/Server.h
-    public_configs = [
-      "${chip_root}/src/lib/address_resolve:default_address_resolve_config",
-    ]
-
     deps += [
       "${chip_root}/third_party/openthread/platforms:libopenthread-platform",
     ]
diff --git a/src/platform/bouffalolab/BL702/BUILD.gn b/src/platform/bouffalolab/BL702/BUILD.gn
@@ -101,14 +101,6 @@ static_library("BL702") {
       ]
       deps += [ "${chip_root}/src/lib/dnssd:platform_header" ]
     }
-
-    # TODO: platform should NOT depend on default_address_resolve_config. This should
-    #       be removed. See https://github.com/project-chip/connectedhomeip/issues/30596
-    #
-    #       Currently this exists because OpenThread platform includes src/app/Server.h
-    public_configs = [
-      "${chip_root}/src/lib/address_resolve:default_address_resolve_config",
-    ]
   }
 
   if (chip_enable_ethernet) {
diff --git a/src/platform/bouffalolab/BL702L/BUILD.gn b/src/platform/bouffalolab/BL702L/BUILD.gn
@@ -88,14 +88,6 @@ static_library("BL702L") {
       ]
       deps += [ "${chip_root}/src/lib/dnssd:platform_header" ]
     }
-
-    # TODO: platform should NOT depend on default_address_resolve_config. This should
-    #       be removed. See https://github.com/project-chip/connectedhomeip/issues/30596
-    #
-    #       Currently this exists because OpenThread platform includes src/app/Server.h
-    public_configs = [
-      "${chip_root}/src/lib/address_resolve:default_address_resolve_config",
-    ]
   }
 
   deps += [ "${chip_root}/src/credentials:credentials_header" ]
diff --git a/src/platform/cc13xx_26xx/cc13x2_26x2/BUILD.gn b/src/platform/cc13xx_26xx/cc13x2_26x2/BUILD.gn
@@ -53,13 +53,6 @@ static_library("cc13x2_26x2") {
     "${chip_root}/src/platform:platform_base",
   ]
 
-  # TODO: platform should NOT depend on default_address_resolve_config. This should
-  #       be removed. See https://github.com/project-chip/connectedhomeip/issues/30596
-  #
-  #       Currently this exists because OpenThread platform includes src/app/Server.h
-  public_configs =
-      [ "${chip_root}/src/lib/address_resolve:default_address_resolve_config" ]
-
   if (chip_enable_ble) {
     sources += [
       "../BLEManagerImpl.cpp",
diff --git a/src/platform/cc13xx_26xx/cc13x4_26x4/BUILD.gn b/src/platform/cc13xx_26xx/cc13x4_26x4/BUILD.gn
@@ -53,13 +53,6 @@ static_library("cc13x4_26x4") {
     "${chip_root}/src/platform:platform_base",
   ]
 
-  # TODO: platform should NOT depend on default_address_resolve_config. This should
-  #       be removed. See https://github.com/project-chip/connectedhomeip/issues/30596
-  #
-  #       Currently this exists because OpenThread platform includes src/app/Server.h
-  public_configs =
-      [ "${chip_root}/src/lib/address_resolve:default_address_resolve_config" ]
-
   if (chip_enable_ble) {
     sources += [
       "../BLEManagerImpl.cpp",
diff --git a/src/platform/nxp/k32w/k32w0/BUILD.gn b/src/platform/nxp/k32w/k32w0/BUILD.gn
@@ -140,14 +140,6 @@ static_library("k32w0") {
       ]
       deps += [ "${chip_root}/src/lib/dnssd:platform_header" ]
     }
-
-    # TODO: platform should NOT depend on default_address_resolve_config. This should
-    #       be removed. See https://github.com/project-chip/connectedhomeip/issues/30596
-    #
-    #       Currently this exists because OpenThread platform includes src/app/Server.h
-    public_configs = [
-      "${chip_root}/src/lib/address_resolve:default_address_resolve_config",
-    ]
   }
 
   public_deps += [ "${chip_root}/src/crypto" ]
diff --git a/src/platform/nxp/k32w/k32w1/BUILD.gn b/src/platform/nxp/k32w/k32w1/BUILD.gn
@@ -106,11 +106,4 @@ static_library("k32w1") {
   }
 
   public_deps += [ "${chip_root}/src/crypto" ]
-
-  # TODO: platform should NOT depend on default_address_resolve_config. This should
-  #       be removed. See https://github.com/project-chip/connectedhomeip/issues/30596
-  #
-  #       Currently this exists because OpenThread platform includes src/app/Server.h
-  public_configs =
-      [ "${chip_root}/src/lib/address_resolve:default_address_resolve_config" ]
 }
diff --git a/src/platform/nxp/rt/rw61x/BUILD.gn b/src/platform/nxp/rt/rw61x/BUILD.gn
@@ -144,13 +144,5 @@ static_library("nxp_platform") {
     "${chip_root}/src/platform:syscalls_stub",
   ]
 
-  public_configs = [
-    ":nxp_platform_config",
-
-    # TODO: platform should NOT depend on default_address_resolve_config. This should
-    #       be removed. See https://github.com/project-chip/connectedhomeip/issues/30596
-    #
-    #       Currently this exists because OpenThread platform includes src/app/Server.h
-    "${chip_root}/src/lib/address_resolve:default_address_resolve_config",
-  ]
+  public_configs = [ ":nxp_platform_config" ]
 }
diff --git a/src/platform/qpg/BUILD.gn b/src/platform/qpg/BUILD.gn
@@ -70,13 +70,8 @@ static_library("qpg") {
       public_deps += [ "${openthread_root}:libopenthread-mtd" ]
     }
 
-    # TODO: platform should NOT depend on default_address_resolve_config. This should
-    #       be removed. See https://github.com/project-chip/connectedhomeip/issues/30596
-    #
-    #       Currently this exists because OpenThread platform includes src/app/Server.h
     public_configs += [
       "${chip_root}/third_party/openthread/platforms/qpg:openthread_qpg_config",
-      "${chip_root}/src/lib/address_resolve:default_address_resolve_config",
     ]
 
     sources += [
diff --git a/src/platform/stm32/BUILD.gn b/src/platform/stm32/BUILD.gn
@@ -89,14 +89,6 @@ static_library("stm32") {
     public_deps += [ "${stm32_sdk_build_root}:stm32_sdk" ]
 
     deps += [ "${chip_root}/src/lib/dnssd:platform_header" ]
-
-    # TODO: platform should NOT depend on default_address_resolve_config. This should
-    #       be removed. See https://github.com/project-chip/connectedhomeip/issues/30596
-    #
-    #       Currently this exists because OpenThread platform includes src/app/Server.h
-    public_configs = [
-      "${chip_root}/src/lib/address_resolve:default_address_resolve_config",
-    ]
   }
 
   # Set the compiler flags

Original file line number	Diff line number	Diff line change
`@@ -83,14 +83,6 @@ static_library("CYW30739") {`
`83`	`83`	`"ThreadStackManagerImpl.h",`
`84`	`84`	`]`
`85`	`85`
`86`		`- # TODO: platform should NOT depend on default_address_resolve_config. This should`
`87`		`- # be removed. See https://github.com/project-chip/connectedhomeip/issues/30596`
`88`		`- #`
`89`		`- # Currently this exists because OpenThread platform includes src/app/Server.h`
`90`		`- public_configs = [`
`91`		`- "${chip_root}/src/lib/address_resolve:default_address_resolve_config",`
`92`		`- ]`
`93`		`-`
`94`	`86`	`deps += [`
`95`	`87`	`"${chip_root}/third_party/openthread/platforms:libopenthread-platform",`
`96`	`88`	`]`
Original file line number	Diff line number	Diff line change
`@@ -101,14 +101,6 @@ static_library("BL702") {`
`101`	`101`	`]`
`102`	`102`	`deps += [ "${chip_root}/src/lib/dnssd:platform_header" ]`
`103`	`103`	`}`
`104`		`-`
`105`		`- # TODO: platform should NOT depend on default_address_resolve_config. This should`
`106`		`- # be removed. See https://github.com/project-chip/connectedhomeip/issues/30596`
`107`		`- #`
`108`		`- # Currently this exists because OpenThread platform includes src/app/Server.h`
`109`		`- public_configs = [`
`110`		`- "${chip_root}/src/lib/address_resolve:default_address_resolve_config",`
`111`		`- ]`
`112`	`104`	`}`
`113`	`105`
`114`	`106`	`if (chip_enable_ethernet) {`
Original file line number	Diff line number	Diff line change
`@@ -88,14 +88,6 @@ static_library("BL702L") {`
`88`	`88`	`]`
`89`	`89`	`deps += [ "${chip_root}/src/lib/dnssd:platform_header" ]`
`90`	`90`	`}`
`91`		`-`
`92`		`- # TODO: platform should NOT depend on default_address_resolve_config. This should`
`93`		`- # be removed. See https://github.com/project-chip/connectedhomeip/issues/30596`
`94`		`- #`
`95`		`- # Currently this exists because OpenThread platform includes src/app/Server.h`
`96`		`- public_configs = [`
`97`		`- "${chip_root}/src/lib/address_resolve:default_address_resolve_config",`
`98`		`- ]`
`99`	`91`	`}`
`100`	`92`
`101`	`93`	`deps += [ "${chip_root}/src/credentials:credentials_header" ]`
Original file line number	Diff line number	Diff line change
`@@ -140,14 +140,6 @@ static_library("k32w0") {`
`140`	`140`	`]`
`141`	`141`	`deps += [ "${chip_root}/src/lib/dnssd:platform_header" ]`
`142`	`142`	`}`
`143`		`-`
`144`		`- # TODO: platform should NOT depend on default_address_resolve_config. This should`
`145`		`- # be removed. See https://github.com/project-chip/connectedhomeip/issues/30596`
`146`		`- #`
`147`		`- # Currently this exists because OpenThread platform includes src/app/Server.h`
`148`		`- public_configs = [`
`149`		`- "${chip_root}/src/lib/address_resolve:default_address_resolve_config",`
`150`		`- ]`
`151`	`143`	`}`
`152`	`144`
`153`	`145`	`public_deps += [ "${chip_root}/src/crypto" ]`
Original file line number	Diff line number	Diff line change
`@@ -106,11 +106,4 @@ static_library("k32w1") {`
`106`	`106`	`}`
`107`	`107`
`108`	`108`	`public_deps += [ "${chip_root}/src/crypto" ]`
`109`		`-`
`110`		`- # TODO: platform should NOT depend on default_address_resolve_config. This should`
`111`		`- # be removed. See https://github.com/project-chip/connectedhomeip/issues/30596`
`112`		`- #`
`113`		`- # Currently this exists because OpenThread platform includes src/app/Server.h`
`114`		`- public_configs =`
`115`		`- [ "${chip_root}/src/lib/address_resolve:default_address_resolve_config" ]`
`116`	`109`	`}`
Original file line number	Diff line number	Diff line change
`@@ -144,13 +144,5 @@ static_library("nxp_platform") {`
`144`	`144`	`"${chip_root}/src/platform:syscalls_stub",`
`145`	`145`	`]`
`146`	`146`
`147`		`- public_configs = [`
`148`		`- ":nxp_platform_config",`
`149`		`-`
`150`		`- # TODO: platform should NOT depend on default_address_resolve_config. This should`
`151`		`- # be removed. See https://github.com/project-chip/connectedhomeip/issues/30596`
`152`		`- #`
`153`		`- # Currently this exists because OpenThread platform includes src/app/Server.h`
`154`		`- "${chip_root}/src/lib/address_resolve:default_address_resolve_config",`
`155`		`- ]`
	`147`	`+ public_configs = [ ":nxp_platform_config" ]`
`156`	`148`	`}`
Original file line number	Diff line number	Diff line change
`@@ -70,13 +70,8 @@ static_library("qpg") {`
`70`	`70`	`public_deps += [ "${openthread_root}:libopenthread-mtd" ]`
`71`	`71`	`}`
`72`	`72`
`73`		`- # TODO: platform should NOT depend on default_address_resolve_config. This should`
`74`		`- # be removed. See https://github.com/project-chip/connectedhomeip/issues/30596`
`75`		`- #`
`76`		`- # Currently this exists because OpenThread platform includes src/app/Server.h`
`77`	`73`	`public_configs += [`
`78`	`74`	`"${chip_root}/third_party/openthread/platforms/qpg:openthread_qpg_config",`
`79`		`- "${chip_root}/src/lib/address_resolve:default_address_resolve_config",`
`80`	`75`	`]`
`81`	`76`
`82`	`77`	`sources += [`