Skip to content

Commit 707a825

Browse files
authored
Fix shutdown ordering in Echo requester/responder (project-chip#7509)
1 parent d29749b commit 707a825

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

src/messaging/tests/echo/common.cpp

+4-2
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
#include <protocols/secure_channel/MessageCounterManager.h>
3131
#include <support/ErrorStr.h>
3232

33-
// The ExchangeManager global object.
33+
chip::SecureSessionMgr gSessionManager;
3434
chip::Messaging::ExchangeManager gExchangeManager;
3535
chip::secure_channel::MessageCounterManager gMessageCounterManager;
3636

@@ -58,6 +58,8 @@ void InitializeChip(void)
5858

5959
void ShutdownChip(void)
6060
{
61-
gExchangeManager.Shutdown();
6261
chip::DeviceLayer::PlatformMgr().Shutdown();
62+
gMessageCounterManager.Shutdown();
63+
gExchangeManager.Shutdown();
64+
gSessionManager.Shutdown();
6365
}

src/messaging/tests/echo/common.h

+2
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,13 @@
2626

2727
#include <messaging/ExchangeMgr.h>
2828
#include <protocols/secure_channel/MessageCounterManager.h>
29+
#include <transport/SecureSessionMgr.h>
2930

3031
constexpr size_t kMaxTcpActiveConnectionCount = 4;
3132
constexpr size_t kMaxTcpPendingPackets = 4;
3233
constexpr size_t kNetworkSleepTimeMsecs = (100 * 1000);
3334

35+
extern chip::SecureSessionMgr gSessionManager;
3436
extern chip::Messaging::ExchangeManager gExchangeManager;
3537
extern chip::secure_channel::MessageCounterManager gMessageCounterManager;
3638

src/messaging/tests/echo/echo_requester.cpp

-2
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
#include <protocols/secure_channel/PASESession.h>
3636
#include <support/ErrorStr.h>
3737
#include <system/SystemPacketBuffer.h>
38-
#include <transport/SecureSessionMgr.h>
3938
#include <transport/raw/TCP.h>
4039
#include <transport/raw/UDP.h>
4140

@@ -60,7 +59,6 @@ chip::Protocols::Echo::EchoClient gEchoClient;
6059

6160
chip::TransportMgr<chip::Transport::UDP> gUDPManager;
6261
chip::TransportMgr<chip::Transport::TCP<kMaxTcpActiveConnectionCount, kMaxTcpPendingPackets>> gTCPManager;
63-
chip::SecureSessionMgr gSessionManager;
6462
chip::Inet::IPAddress gDestAddr;
6563

6664
// The last time a CHIP Echo was attempted to be sent.

src/messaging/tests/echo/echo_responder.cpp

-2
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
#include <protocols/secure_channel/PASESession.h>
3636
#include <support/ErrorStr.h>
3737
#include <system/SystemPacketBuffer.h>
38-
#include <transport/SecureSessionMgr.h>
3938
#include <transport/raw/TCP.h>
4039
#include <transport/raw/UDP.h>
4140

@@ -45,7 +44,6 @@ namespace {
4544
chip::Protocols::Echo::EchoServer gEchoServer;
4645
chip::TransportMgr<chip::Transport::UDP> gUDPManager;
4746
chip::TransportMgr<chip::Transport::TCP<kMaxTcpActiveConnectionCount, kMaxTcpPendingPackets>> gTCPManager;
48-
chip::SecureSessionMgr gSessionManager;
4947
chip::SecurePairingUsingTestSecret gTestPairing;
5048

5149
// Callback handler when a CHIP EchoRequest is received.

0 commit comments

Comments
 (0)