Skip to content

Commit a23f0bd

Browse files
Increase pairing timeouts in darwin tests. (project-chip#35698)
We've had a few test failures where the server app starts up _really_ slowly, to the point that it takes about 10 seconds just to get it started and advertising. And if we're waiting to discover it, 10 seconds is just not long enough to commission if that's how long it takes to start up.
1 parent 1a39969 commit a23f0bd

9 files changed

+9
-9
lines changed

src/darwin/Framework/CHIPTests/MTRBackwardsCompatTests.m

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030

3131
// Fixture: chip-all-clusters-app --KVS "$(mktemp -t chip-test-kvs)" --interface-id -1
3232

33-
static const uint16_t kPairingTimeoutInSeconds = 10;
33+
static const uint16_t kPairingTimeoutInSeconds = 30;
3434
static const uint16_t kCASESetupTimeoutInSeconds = 30;
3535
static const uint16_t kTimeoutInSeconds = 3;
3636
static const uint64_t kDeviceId = 0x12344321;

src/darwin/Framework/CHIPTests/MTRCertificateValidityTests.m

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
// system dependencies
2727
#import <XCTest/XCTest.h>
2828

29-
static const uint16_t kPairingTimeoutInSeconds = 10;
29+
static const uint16_t kPairingTimeoutInSeconds = 30;
3030
static const uint16_t kTimeoutInSeconds = 3;
3131
static const uint64_t kDeviceId = 0x12341234;
3232
static const uint64_t kControllerId = 0x56788765;

src/darwin/Framework/CHIPTests/MTRDeviceTests.m

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343

4444
// Fixture: chip-all-clusters-app --KVS "$(mktemp -t chip-test-kvs)" --interface-id -1
4545

46-
static const uint16_t kPairingTimeoutInSeconds = 10;
46+
static const uint16_t kPairingTimeoutInSeconds = 30;
4747
static const uint16_t kTimeoutInSeconds = 3;
4848
static const uint64_t kDeviceId = 0x12344321;
4949
static NSString * kOnboardingPayload = @"MT:-24J0AFN00KA0648G00";

src/darwin/Framework/CHIPTests/MTROTAProviderTests.m

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646

4747
#if ENABLE_OTA_TESTS
4848

49-
static const uint16_t kPairingTimeoutInSeconds = 10;
49+
static const uint16_t kPairingTimeoutInSeconds = 30;
5050
static const uint16_t kTimeoutInSeconds = 3;
5151
static const uint16_t kTimeoutWithUpdateInSeconds = 60;
5252
static const uint64_t kDeviceId1 = 0x12341234;

src/darwin/Framework/CHIPTests/MTROperationalCertificateIssuerTests.m

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
// system dependencies
2525
#import <XCTest/XCTest.h>
2626

27-
static const uint16_t kPairingTimeoutInSeconds = 10;
27+
static const uint16_t kPairingTimeoutInSeconds = 30;
2828
static const uint64_t kDeviceId = 0x12344321;
2929
static NSString * kOnboardingPayload = @"MT:-24J0AFN00KA0648G00";
3030
static const uint16_t kLocalPort = 5541;

src/darwin/Framework/CHIPTests/MTRPairingTests.m

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
#import "MTRTestKeys.h"
2727
#import "MTRTestStorage.h"
2828

29-
static const uint16_t kPairingTimeoutInSeconds = 10;
29+
static const uint16_t kPairingTimeoutInSeconds = 30;
3030
static const uint16_t kTimeoutInSeconds = 3;
3131
static uint64_t sDeviceId = 100000000;
3232
static NSString * kOnboardingPayload = @"MT:Y.K90SO527JA0648G00";

src/darwin/Framework/CHIPTests/MTRPerControllerStorageTests.m

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
#import "MTRTestPerControllerStorage.h"
3333
#import "MTRTestResetCommissioneeHelper.h"
3434

35-
static const uint16_t kPairingTimeoutInSeconds = 10;
35+
static const uint16_t kPairingTimeoutInSeconds = 30;
3636
static const uint16_t kTimeoutInSeconds = 3;
3737
static const uint16_t kSubscriptionTimeoutInSeconds = 60;
3838
static NSString * kOnboardingPayload = @"MT:-24J0AFN00KA0648G00";

src/darwin/Framework/CHIPTests/MTRSwiftDeviceTests.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ struct DeviceConstants {
1010
static let onboardingPayload = "MT:-24J0AFN00KA0648G00"
1111
static let deviceID = 0x12344321
1212
static let timeoutInSeconds : Double = 3
13-
static let pairingTimeoutInSeconds : Double = 10
13+
static let pairingTimeoutInSeconds : Double = 30
1414
}
1515

1616
var sConnectedDevice: MTRBaseDevice? = nil

src/darwin/Framework/CHIPTests/MTRXPCListenerSampleTests.m

+1-1
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,7 @@ - (void)readAttributeCacheWithController:(id _Nullable)controller
415415

416416
@end
417417

418-
static const uint16_t kPairingTimeoutInSeconds = 10;
418+
static const uint16_t kPairingTimeoutInSeconds = 30;
419419
static const uint16_t kTimeoutInSeconds = 3;
420420
static const uint64_t kDeviceId = 0x12344321;
421421
static NSString * kOnboardingPayload = @"MT:-24J0AFN00KA0648G00";

0 commit comments

Comments
 (0)