-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
File editor extension does not add a launcher card when a spec is added after launch #17549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
4 tasks
For reference the notebook extension properly handles new kernel specs: jupyterlab/packages/notebook-extension/src/index.ts Lines 2017 to 2056 in 7160c30
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Currently the
@jupyterlab/fileeditor-extension
adds new cards to the launcher for some known types to create new Python, R and Julia files:jupyterlab/packages/fileeditor-extension/src/index.ts
Lines 392 to 406 in 7160c30
This function is used here in the plugin:
jupyterlab/packages/fileeditor-extension/src/index.ts
Lines 568 to 592 in 7160c30
However it does not react to specs added later via the
specsChanged
signal. So only the notebook and console sections are correctly updated when a new spec is available.Reproduce
ipykernel
ipykernel
jupyterlab-dynamic-launcher-card-python.mp4
Expected behavior
The "Other" category should also have the Python card after the specs have been refreshed.
Context
Noticed downstream in jupyterlite/jupyterlite#1642 (via jupyterlite/pyodide-kernel#177) with the Pyodide kernel being added after the launcher plugin has been activated.
The text was updated successfully, but these errors were encountered: