From 46fd867f2d800ebc58f16b65f6c70ebb924152c6 Mon Sep 17 00:00:00 2001 From: Simon Schneegans Date: Thu, 20 Jun 2024 19:45:49 +0200 Subject: [PATCH] :arrow_down: Downgrade electron to version 30 to avoid glitches on macOS --- docs/changelog.md | 2 +- package-lock.json | 8 ++++---- package.json | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/changelog.md b/docs/changelog.md index c435b302..4e121710 100644 --- a/docs/changelog.md +++ b/docs/changelog.md @@ -31,7 +31,7 @@ This changelog follows the rules of [Keep a Changelog](http://keepachangelog.com - On macOS, the application settings are now stored in `~/Library/Application Support/kando/` (with a lowercase `kando`). This is more consistent with the other platforms and macOS seems to handle this in a case-insensitive way, so the settings should be preserved when upgrading from an older version. - When a menu is opened in screen-center mode, turbo-mode is now disabled initially. This is to prevent accidental navigation when the menu is opened and a key is still pressed. Once all keyboard keys are released, turbo-mode can be activated by pressing and holding any key. -- Updated from Electron 28 to Electron 31. This should bring some performance improvements. However, there's also a regression on X11 Linux where getting the mouse position before opening the menu is not reliable anymore. Therefore, a custom implementation is used on X11 Linux now. Report any issues you encounter, especially on fractional scaling setups! +- Updated from Electron 28 to Electron 30. This should bring some performance improvements. However, there's also a regression on X11 Linux where getting the mouse position before opening the menu is not reliable anymore. Therefore, a custom implementation is used on X11 Linux now. Report any issues you encounter, especially on fractional scaling setups! - The description line of hotkey items in the stash or in the trash now shows the hotkey in a shorter format. For instance, "ControlLeft+AltLeft+ArrowRight" is now shown as "Ctrl + Alt + ArrowRight". - An [ESLint rule](https://typescript-eslint.io/rules/naming-convention/) which enforces naming conventions is used now. This should make the code more consistent, easier to read, and easier to contribute to. - Another [ESLint rule](https://eslint.org/docs/latest/rules/curly) which enforces the use of curly braces for all control statements is used now. This should make the code more consistent and less error-prone. diff --git a/package-lock.json b/package-lock.json index 9a8c3d19..935fc8af 100644 --- a/package-lock.json +++ b/package-lock.json @@ -44,7 +44,7 @@ "cmake-js": "^7.3.0", "copy-webpack-plugin": "^12.0.2", "css-loader": "^7.1.1", - "electron": "^31.0.1", + "electron": "^30.1.2", "eslint": "^8.56.0", "eslint-plugin-import": "^2.29.1", "fork-ts-checker-webpack-plugin": "^9.0.2", @@ -4228,9 +4228,9 @@ "dev": true }, "node_modules/electron": { - "version": "31.0.2", - "resolved": "https://registry.npmjs.org/electron/-/electron-31.0.2.tgz", - "integrity": "sha512-55efQ5yfLN+AQHcFC00AXQqtxC3iAGaxX2GQ3EDbFJ0ca9GHNOdSXkcrdBElLleiDrR2hpXNkQxN1bDn0oxe6w==", + "version": "30.1.2", + "resolved": "https://registry.npmjs.org/electron/-/electron-30.1.2.tgz", + "integrity": "sha512-A5CFGwbA+HSXnzwjc8fP2GIezBcAb0uN/VbNGLOW8DHOYn07rvJ/1bAJECHUUzt5zbfohveG3hpMQiYpbktuDw==", "dev": true, "hasInstallScript": true, "dependencies": { diff --git a/package.json b/package.json index a95bd2ad..7259fe30 100644 --- a/package.json +++ b/package.json @@ -37,7 +37,7 @@ "cmake-js": "^7.3.0", "copy-webpack-plugin": "^12.0.2", "css-loader": "^7.1.1", - "electron": "^31.0.1", + "electron": "^30.1.2", "eslint": "^8.56.0", "eslint-plugin-import": "^2.29.1", "fork-ts-checker-webpack-plugin": "^9.0.2",