Skip to content

Commit 9f9c1c3

Browse files
felixscherzankatiyar
andauthoredOct 10, 2024··
chore: remove python 3.8 support for kedro-docker (#876)
* chore: remove python 3.8 support for kedro-docker Signed-off-by: Felix Scherz <felixwscherz@gmail.com> * docs: update release notes Signed-off-by: Felix Scherz <felixwscherz@gmail.com> * ci: remove python 3.8 from airflow and telemetry Signed-off-by: Felix Scherz <felixwscherz@gmail.com> * docs: remove Python3.8 from README Signed-off-by: Felix Scherz <felixwscherz@gmail.com> --------- Signed-off-by: Felix Scherz <felixwscherz@gmail.com> Co-authored-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com>
1 parent 6adb823 commit 9f9c1c3

File tree

8 files changed

+16
-11
lines changed

8 files changed

+16
-11
lines changed
 

‎.pre-commit-config.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ repos:
5151
exclude: ^(?!kedro-docker/kedro_docker/).*\.py$
5252
pass_filenames: false
5353
stages: [ manual ]
54-
entry: ruff kedro-docker --fix --exit-non-zero-on-fix
54+
entry: ruff check kedro-docker --fix --exit-non-zero-on-fix
5555

5656
- id: ruff-kedro-telemetry
5757
name: "Ruff on kedro_telemetry/*"

‎kedro-docker/README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Kedro-Docker
22

3-
[![Python Version](https://img.shields.io/badge/python-3.8%20%7C%203.9%20%7C%203.10%20%7C%203.11%20%7C%203.12-blue.svg)](https://pypi.org/project/kedro-docker/)
3+
[![Python Version](https://img.shields.io/badge/python-3.9%20%7C%203.10%20%7C%203.11%20%7C%203.12-blue.svg)](https://pypi.org/project/kedro-docker/)
44
[![PyPI version](https://badge.fury.io/py/kedro-docker.svg)](https://pypi.org/project/kedro-docker/)
55
[![License](https://img.shields.io/badge/license-Apache%202.0-blue.svg)](https://opensource.org/licenses/Apache-2.0)
66
[![Code Style: Black](https://img.shields.io/badge/code%20style-black-black.svg)](https://github.com/ambv/black)
@@ -63,7 +63,7 @@ Behind the scenes Kedro does the following:
6363
6464
> *Note:* By default, `kedro docker build` creates an image without Spark and Hadoop.
6565
66-
> *Note:* By default, when calling `kedro docker build` image is built with `python:VERSION-buster` image, where VERSION is Python (major + minor) version from the current environment. By specifying `--base-image` option, different base image can be used. For example `kedro docker build --base-image="python:3.8-buster"`.
66+
> *Note:* By default, when calling `kedro docker build` image is built with `python:VERSION-buster` image, where VERSION is Python (major + minor) version from the current environment. By specifying `--base-image` option, different base image can be used. For example `kedro docker build --base-image="python:3.9-buster"`.
6767
6868
> *Note:* You can generate the `Dockerfile`, `.dockerignore` or `.dive-ci` files without building the image by running `kedro docker init`. This might be of use in case you would like to modify these files before the first build.
6969

‎kedro-docker/RELEASE.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Upcoming Release
22

3+
# Release 0.7.0
4+
## Major features and improvements
5+
* Removed support for python 3.8
6+
37
# Release 0.6.1
48
* Unpinned pip version requirement
59

‎kedro-docker/features/steps/sh_run.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import shlex
22
import subprocess
3-
from typing import Sequence, Union
3+
from collections.abc import Sequence
4+
from typing import Union
45

56
import psutil
67

‎kedro-docker/features/steps/util.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
from pathlib import Path
77
from threading import Thread
88
from time import sleep, time
9-
from typing import Any, Callable, List
9+
from typing import Any, Callable
1010

1111
import docker
1212
from kedro.framework.cli.utils import get_pkg_version
@@ -130,7 +130,7 @@ def init_docker_client(**kwargs) -> docker.client.DockerClient:
130130
return docker.from_env(**kwargs)
131131

132132

133-
def get_docker_containers(name: str) -> List[docker.models.containers.Container]:
133+
def get_docker_containers(name: str) -> list[docker.models.containers.Container]:
134134
"""
135135
Get list of docker containers which contain `name` in their names.
136136
@@ -164,7 +164,7 @@ def docker_prune():
164164
client.images.prune()
165165

166166

167-
def get_docker_images(name: str) -> List[docker.models.images.Image]:
167+
def get_docker_images(name: str) -> list[docker.models.images.Image]:
168168
"""
169169
Get docker images with `name` in their names.
170170

‎kedro-docker/kedro_docker/helpers.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@
77
import shutil
88
import socket
99
import subprocess
10+
from collections.abc import Sequence
1011
from importlib import import_module
1112
from itertools import chain
1213
from pathlib import Path, PurePosixPath
1314
from subprocess import DEVNULL, PIPE
14-
from typing import Sequence
1515

1616
from click import secho
1717
from kedro.framework.cli.utils import KedroCliError

‎kedro-docker/kedro_docker/plugin.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22

33
import shlex
44
import subprocess
5+
from collections.abc import Sequence
56
from pathlib import Path
67
from sys import version_info
7-
from typing import Dict, Sequence
88

99
import click
1010
from kedro import __version__ as kedro_version
@@ -191,7 +191,7 @@ def docker_build(ctx, uid, gid, spark, base_image, image, docker_args): # noqa:
191191
call(command)
192192

193193

194-
def _mount_info() -> Dict[str, Sequence[str]]:
194+
def _mount_info() -> dict[str, Sequence[str]]:
195195
res = {
196196
"host_root": str(Path.cwd()),
197197
"container_root": "/home/kedro_docker",

‎kedro-docker/pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ authors = [
88
{name = "Kedro"}
99
]
1010
description = "Kedro-Docker makes it easy to package Kedro projects with Docker."
11-
requires-python = ">=3.8"
11+
requires-python = ">=3.9"
1212
license = {text = "Apache Software License (Apache 2.0)"}
1313
dependencies = [
1414
"anyconfig~=0.10.0", # not directly required, pinned by Snyk to avoid a vulnerability

0 commit comments

Comments
 (0)
Please sign in to comment.