Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Transaction Failure Issue When Tipping Using ArgentX Desktop #245

Closed
lauchaves opened this issue Jul 23, 2024 · 7 comments · Fixed by #291
Closed

Fix Transaction Failure Issue When Tipping Using ArgentX Desktop #245

lauchaves opened this issue Jul 23, 2024 · 7 comments · Fixed by #291
Assignees

Comments

@lauchaves
Copy link
Contributor

Description

Issue

  • When tipping using argentX desktop extension, the transaction fails

Expected

  • transactions succeed, allow tipping

Screenshots

image

image

@ugur-eren ugur-eren self-assigned this Jul 23, 2024
@ugur-eren
Copy link
Collaborator

Hi clicking the copy button next to the error message will copy the whole error message. Can you share that?

resim

@lauchaves
Copy link
Contributor Author

hey! @ugur-eren here it is

Error in the called contract (0x016d6b7d8ba15d1903ea942a6e9414a70b0f1b2219215dc46faca9a38a522d06): Error at pc=0:15213: Got an exception while executing a hint: Requested contract address ContractAddress(PatriciaKey(StarkFelt("0x078a022e6906c83e049a30f7464b939b831ecbe47029480d7e89684f20c8d263"))) is not deployed. Cairo traceback (most recent call last): Unknown location (pc=0:222) Unknown location (pc=0:4845) Unknown location (pc=0:10647) Unknown location (pc=0:15231)

@ugur-eren
Copy link
Collaborator

Are you trying on the mainnet? Currently only sepolia is supported.

@ugur-eren ugur-eren reopened this Jul 23, 2024
@ugur-eren
Copy link
Collaborator

This issue can be assigned to contributors who want to implement it.s

There should be a check for connect account's chain id. If the chain is not Starknet Sepolia, app should show a uncloseable dialog with
title: 'Wrong Network'
message: 'Joyboy currently only supports Starknet Sepolia network. Please switch to Sepolia network to continue.'

@lauchaves
Copy link
Contributor Author

got it!, yeah its mainnet
image

@lauchaves
Copy link
Contributor Author

This issue can be assigned to contributors who want to implement it.s

There should be a check for connect account's chain id. If the chain is not Starknet Sepolia, app should show a uncloseable dialog with title: 'Wrong Network' message: 'Joyboy currently only supports Starknet Sepolia network. Please switch to Sepolia network to continue.'

@ugur-eren If you agree, I can take care of this 😃

@ugur-eren ugur-eren assigned lauchaves and unassigned ugur-eren Jul 23, 2024
lauchaves pushed a commit to lauchaves/joyboy that referenced this issue Jul 25, 2024
lauchaves pushed a commit to lauchaves/joyboy that referenced this issue Jul 25, 2024
lauchaves pushed a commit to lauchaves/joyboy that referenced this issue Jul 25, 2024
lauchaves pushed a commit to lauchaves/joyboy that referenced this issue Jul 25, 2024
lauchaves pushed a commit to lauchaves/joyboy that referenced this issue Jul 25, 2024
@lauchaves
Copy link
Contributor Author

JM @ugur-eren this is ready for review! Here's the PR

@ugur-eren ugur-eren linked a pull request Jul 25, 2024 that will close this issue
ugur-eren added a commit that referenced this issue Jul 25, 2024
* #245: add network check sepolia

* Applying Code Review

* Fix network

---------

Co-authored-by: lauchaves <lauchavesmendez@gmail.comA>
Co-authored-by: Uğur Eren <contact@ugureren.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants