Skip to content

Commit bf65384

Browse files
committed
Fix tests after supporting the newer API
1 parent be1597e commit bf65384

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

github/pullRequest_test.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ func TestFillDetails(t *testing.T) {
103103
err := pr.FillDetails(apiMock{
104104
diffSizeErr: fmt.Errorf("Weird error"),
105105
})
106-
require.EqualError(t, err, "Weird error")
106+
require.EqualError(t, err, "diff size: Weird error")
107107
})
108108

109109
t.Run("Fails when couldn't fetch the comments", func(t *testing.T) {
@@ -114,7 +114,7 @@ func TestFillDetails(t *testing.T) {
114114
err := pr.FillDetails(apiMock{
115115
commentsErr: fmt.Errorf("Weird error"),
116116
})
117-
require.EqualError(t, err, "Weird error")
117+
require.EqualError(t, err, "comments: Weird error")
118118
})
119119

120120
t.Run("Fails when couldn't fetch the review requests", func(t *testing.T) {
@@ -125,7 +125,7 @@ func TestFillDetails(t *testing.T) {
125125
err := pr.FillDetails(apiMock{
126126
reviewRequestsErr: fmt.Errorf("Weird error"),
127127
})
128-
require.EqualError(t, err, "Weird error")
128+
require.EqualError(t, err, "review requests: Weird error")
129129
})
130130
}
131131

github/reviewRequest_test.go

+3-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@ func TestReviewRequest(t *testing.T) {
1616
HTTPClient: httpClientMock{func() (*http.Response, error) {
1717
return &http.Response{
1818
StatusCode: 200,
19-
Body: ioutil.NopCloser(strings.NewReader(`[{"login": "User1"}]`)),
19+
Body: ioutil.NopCloser(strings.NewReader(
20+
`{"users": [{"login": "User1"}], "teams": []}`,
21+
)),
2022
}, nil
2123
}},
2224
RepoName: "someuser/somerepo",

github/util/github_util_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ func TestFillDetails(t *testing.T) {
138138
}
139139
}
140140

141-
require.EqualError(t, err, "Fetching error")
141+
require.EqualError(t, err, "diff size: Fetching error")
142142
})
143143
}
144144

0 commit comments

Comments
 (0)