Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure setAttribute fires after editor is ready #154

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Ensure setAttribute fires after editor is ready #154

merged 1 commit into from
Sep 6, 2024

Conversation

ValenMorales
Copy link
Contributor

Fixed issue #148 by ensuring that setAttribute is called only after the editor DOM elements are fully loaded, preventing errors caused by accessing elements that are not yet available.

closes #148

@ValenMorales ValenMorales marked this pull request as ready for review September 6, 2024 15:26
L-Zuluaga
L-Zuluaga approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@L-Zuluaga L-Zuluaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to be, good job 👍🏻

@ValenMorales ValenMorales merged commit 510964f into kommitters:v1.1 Sep 6, 2024
3 checks passed
ValenMorales added a commit that referenced this pull request Sep 6, 2024
@ValenMorales
Release v1.1.15 (#156)
f19e977 
* Update README.md (#152)

Example and section added on plugin usage and customizing the indicator style to enhance documentation clarity.

* Ensure setAttribute fires after editor is ready (#154)

* Updated changelog and package.json for release 1.1.15 (#155)
@L-Zuluaga L-Zuluaga linked an issue Jan 20, 2025 that may be closed by this pull request
This problem can occur after a few refreshes #157
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-Zuluaga L-Zuluaga L-Zuluaga approved these changes

Assignees

@ValenMorales ValenMorales

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

This problem can occur after a few refreshes
2 participants
@ValenMorales @L-Zuluaga