Skip to content

Move integration test code into the components #129

@kimwnasptd

Description

@kimwnasptd

Checks

Motivation

This is a follow-up from #126 (comment), while working on #121 as part of the first release #125

Right now are testing code looks like this:

  1. Integration tests are run via bash scripts
  2. Those bash scripts live inside testing/gh-actions folder
  3. There are also scripts in testing/gh-actions for installing dependencies like KinD, Istio etc
  4. There are test files, for different components, that need to get applied inside testing/gh-actions

While the above has worked well for the manifests repo, which aggregates components, in this repo though (IMO) we are now making a convoluted structure.

The test driving code (scripts) and the necessary files are now all gathered in testing/gh-actions. Thus this dir will keep growing more and more if we don't put some more structure.

Implementation

My suggestion would be to think about:

  1. Keeping only scripts that install dependencies (KinD, Istio etc) in testing/gh-actions
  2. Move all the testing files (driver scripts and test files) to the corresponding component
    • Maybe a folder named integration? Open to suggestions
  3. The .github/workflows will contain the logic for triggering the scripts of components, by running them from their corrsponding folder

Are you willing & able to help?

  • I am able to submit a PR!
  • I can help test the feature!

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions