-
Notifications
You must be signed in to change notification settings - Fork 19
Open
Labels
kind/enhancementkind - new features or changeskind - new features or changespriority/needs-triagepriority - needs to be triagedpriority - needs to be triaged
Description
Checks
- I have searched the existing issues.
- My request is related to one of the components in the
kubeflow/dashboard
repository.
Motivation
This is a follow-up from #126 (comment), while working on #121 as part of the first release #125
Right now are testing code looks like this:
- Integration tests are run via bash scripts
- Those bash scripts live inside
testing/gh-actions
folder - There are also scripts in
testing/gh-actions
for installing dependencies like KinD, Istio etc - There are test files, for different components, that need to get applied inside
testing/gh-actions
While the above has worked well for the manifests repo, which aggregates components, in this repo though (IMO) we are now making a convoluted structure.
The test driving code (scripts) and the necessary files are now all gathered in testing/gh-actions
. Thus this dir will keep growing more and more if we don't put some more structure.
Implementation
My suggestion would be to think about:
- Keeping only scripts that install dependencies (KinD, Istio etc) in
testing/gh-actions
- Move all the testing files (driver scripts and test files) to the corresponding component
- Maybe a folder named
integration
? Open to suggestions
- Maybe a folder named
- The
.github/workflows
will contain the logic for triggering the scripts of components, by running them from their corrsponding folder
Are you willing & able to help?
- I am able to submit a PR!
- I can help test the feature!
Metadata
Metadata
Assignees
Labels
kind/enhancementkind - new features or changeskind - new features or changespriority/needs-triagepriority - needs to be triagedpriority - needs to be triaged