Add check for lost target PVC in populators

Signed-off-by: Alvaro Romero <alromero@redhat.com>

Author: alromeros

pkg/controller/common/util.go

@@ -1578,6 +1578,11 @@ func IsUnbound(pvc *corev1.PersistentVolumeClaim) bool {
 	return !IsBound(pvc)
 }
 
+// IsLost returns if the pvc is lost
+func IsLost(pvc *corev1.PersistentVolumeClaim) bool {
+	return pvc != nil && pvc.Status.Phase == corev1.ClaimLost
+}
+
 // IsImageStream returns true if registry source is ImageStream
 func IsImageStream(pvc *corev1.PersistentVolumeClaim) bool {
 	return pvc.Annotations[AnnRegistryImageStream] == "true"

pkg/controller/populators/populator-base.go

@@ -342,10 +342,10 @@ func (r *ReconcilerBase) reconcileCommon(pvc *corev1.PersistentVolumeClaim, popu
 		return nil, err
 	}
 
-	// If PVC' doesn't exist and target PVC is not bound, we should create the PVC' to start the population.
+	// If PVC' doesn't exist and target PVC is rebindable, we should create the PVC' to start the population.
 	// We still return nil as we'll get called again once PVC' exists.
 	// If target PVC is bound, we don't really need to populate anything.
-	if cc.IsUnbound(pvc) {
+	if cc.IsUnbound(pvc) && !cc.IsLost(pvc) {
 		_, err := r.createPVCPrime(pvc, populationSource, nodeName != "", populator.updatePVCForPopulation)
 		if err != nil {
 			r.recorder.Eventf(pvc, corev1.EventTypeWarning, errCreatingPVCPrime, err.Error())

pkg/controller/transfer/pvc.go

@@ -43,7 +43,7 @@ func (h *pvcTransferHandler) ReconcilePending(ot *cdiv1.ObjectTransfer) (time.Du
 		return 0, nil
 	}
 
-	if cc.IsUnbound(pvc) || pvc.Status.Phase != corev1.ClaimBound {
+	if cc.IsUnbound(pvc) {
 		if err := h.reconciler.setAndUpdateCompleteCondition(ot, corev1.ConditionFalse, "PVC not bound", ""); err != nil {
 			return 0, err
 		}