Fix another issues in multi-arch images (#3313)

* Fix another issue in multi-arch images

Follow-up of PR #3303 - need to push the images before creating the
manifest, also for the index image.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* Enable multi-ach images on nightly test

Install qemu-user-static, to allow running binary from one arch, on
image build for another arch.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

---------

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

Author: nunnatsa

automation/nightly/test-nightly-build.sh

@@ -18,10 +18,13 @@ function dump() {
 
 # Get golang
 $CRI_BIN login --username "$(cat "${QUAY_USER}")" --password-stdin quay.io < "${QUAY_PASSWORD}"
-wget -q https://dl.google.com/go/go1.22.6.linux-amd64.tar.gz
+wget -q https://dl.google.com/go/go1.23.5.linux-amd64.tar.gz
 tar -C /usr/local -xf go*.tar.gz
 export PATH=/usr/local/go/bin:$PATH
 
+# add qemu-user-static
+$CRI_BIN run --rm --privileged docker.io/multiarch/qemu-user-static --reset -p yes
+
 # get latest KubeVirt commit
 latest_kubevirt=$(curl -sL https://storage.googleapis.com/kubevirt-prow/devel/nightly/release/kubevirt/kubevirt/latest)
 latest_kubevirt_image=$(curl -sL "https://storage.googleapis.com/kubevirt-prow/devel/nightly/release/kubevirt/kubevirt/${latest_kubevirt}/kubevirt-operator.yaml" | grep 'OPERATOR_IMAGE' -A1 | tail -n 1 | sed 's/.*value: //g')

hack/build-index-image.sh

@@ -84,8 +84,10 @@ function create_file_based_catalog() {
 
   IMAGES=
   for arch in ${ARCHITECTURES}; do
-    podman build --platform="linux/${arch}" -t "${INDEX_IMAGE_NAME}-${arch}" -f fbc-catalog.Dockerfile
-    IMAGES="${IMAGES} ${INDEX_IMAGE_NAME}-${arch}"
+    current_image="${INDEX_IMAGE_NAME}-${arch}"
+    podman build --platform="linux/${arch}" -t "${current_image}" -f fbc-catalog.Dockerfile
+    podman push "${current_image}"
+    IMAGES="${IMAGES} ${current_image}"
   done
 
   podman manifest create "${INDEX_IMAGE_NAME}" ${IMAGES}