Merged in feature/update_version (pull request #1)

KBP-166 #time 5h - update code and version for rails 4 to version 0.5

Approved-by: İsmail Akbudak <ismail.akbudak@lab2023.com>
Approved-by: Fatih Avsan <fatih.avsan@lab2023.com>

Author: Hamdi Bayhan

.gitignore

@@ -17,4 +17,5 @@ test/version_tmp
 tmp
 .idea
 .idea/**/*
-atlassian-ide-plugin.xml
+atlassian-ide-plugin.xml
+.DS_Store

.rubocop.yml

@@ -0,0 +1,45 @@
+AllCops:
+  Include:
+    - 'Rakefile'
+    - 'config.ru'
+    - 'Gemfile'
+  Exclude:
+    - Guardfile
+    - bin/**
+    - db/**/**
+    - scripts/**
+    - spec/**/**/**/**
+    - test/**/**/**/**
+    - tmp/**/**/**/**
+    - lib/modules/**/**
+Documentation:
+  Enabled: false
+
+Metrics/LineLength:
+  Max: 100
+  Exclude:
+    - 'Gemfile'
+
+Metrics/MethodLength:
+  CountComments: false
+  Max: 20
+
+Metrics/AbcSize:
+  Max: 40
+
+Metrics/CyclomaticComplexity:
+  Max: 10
+
+Metrics/PerceivedComplexity:
+  Max: 10
+
+Metrics/BlockLength:
+  CountComments: false
+  Max: 40
+  Exclude:
+    - 'Rakefile'
+    - '**/*.rake'
+    - 'spec/**/*.rb'
+
+Style/FrozenStringLiteralComment:
+  EnforcedStyle: when_needed

Gemfile

@@ -3,13 +3,14 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in tcmb_currency.gemspec
 gemspec
 
-gem 'yard', ">= 0.5.8"
-gem 'json', ">= 1.4.0"
-gem 'yajl-ruby', ">= 1.0.0"
 gem 'ffi'
-gem 'money'
-gem 'money-rails'
+gem 'json', '>= 1.4.0'
+gem 'money', '~> 6.7.1'
+gem 'money-rails', '~> 1.7'
 gem 'nokogiri'
+gem 'rubocop', '~> 0.51.0'
+gem 'yajl-ruby', '>= 1.0.0'
+gem 'yard', '>= 0.5.8'
 
 group :development do
   gem 'rake'

README.md

@@ -14,11 +14,8 @@ Add this line to your application's Gemfile:
 
     ### For rails 4.x
 
-    gem 'tcmb_currency', '~> 0.4.0', :git => 'git://github.com/lab2023/tcmb_currency.git'
+    gem 'tcmb_currency', '~> 0.5.0', :git => 'git://github.com/lab2023/tcmb_currency.git'
 
-    ### For rails 3.x
-
-    gem 'tcmb_currency', '~> 0.3.0', git: 'git://github.com/lab2023/tcmb_currency.git', branch: 'rails3'
 
 And then execute:
 
@@ -52,6 +49,8 @@ And you can use it as
 	Money.new(1000,"USD").exchange_to(:EUR)
 	Money.new(1000,"USD").exchange_to(:EUR, "2013-03-02")
 
+If there is no record for searches with history, you will get `There is no record in that date` error.
+	
 ## Contributing
 
 Once you've made your great commits:

Rakefile

@@ -1 +1 @@
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'

lib/generators/tcmb_currency/initializer/initializer_generator.rb

@@ -3,14 +3,12 @@
 
 module TcmbCurrency
   class InitializerGenerator < ::Rails::Generators::Base
+    source_root File.join(File.dirname(__FILE__), 'templates')
 
-      source_root File.join(File.dirname(__FILE__), 'templates')
-
-      desc 'Creates a sample Tcmb_Currency initializer.'
-
-      def copy_initializer
-        copy_file 'money.rb', 'config/initializers/money.rb'
-      end
+    desc 'Creates a sample Tcmb_Currency initializer.'
 
+    def copy_initializer
+      copy_file 'money.rb', 'config/initializers/money.rb'
     end
-end
+  end
+end

lib/generators/tcmb_currency/initializer/templates/money.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 # encoding : utf-8
 require 'money'
 require 'money/bank/tcmb_currency'
 require 'json'
 MultiJson.engine = :json_gem
 Money.default_bank = Money::Bank::TcmbCurrency.new
 CROSS_RATE = Money::Bank::TcmbCurrency::CrossRate
-CURRENCY_TYPE = Money::Bank::TcmbCurrency::CurrencyType
+CURRENCY_TYPE = Money::Bank::TcmbCurrency::CurrencyType

lib/generators/tcmb_currency/migration/migration_generator.rb

@@ -5,7 +5,7 @@ module TcmbCurrency
   class MigrationGenerator < Rails::Generators::Base
     include Rails::Generators::Migration
 
-    namespace "tcmb_currency:migration"
+    namespace 'tcmb_currency:migration'
 
     source_root File.join(File.dirname(__FILE__), 'templates')
 
@@ -14,8 +14,10 @@ def self.next_migration_number(dirname)
     end
 
     def create_migration_file
-      migration_template 'typemigration.rb', 'db/migrate/create_currency_types.rb' rescue nil
-      migration_template 'migration.rb', 'db/migrate/create_cross_rates_table.rb' rescue nil
+      migration_template 'typemigration.rb', 'db/migrate/create_currency_types.rb'
+      migration_template 'migration.rb', 'db/migrate/create_cross_rates_table.rb'
+    rescue StandardError => e
+      raise e
     end
   end
-end
+end

lib/generators/tcmb_currency/migration/templates/migration.rb

@@ -13,4 +13,4 @@ def self.up
   def self.down
     drop_table :cross_rates
   end
-end
+end

lib/generators/tcmb_currency/migration/templates/typemigration.rb

@@ -5,8 +5,8 @@ def self.up
 
       t.timestamps
     end
-
-    currencies = ['USD', 'EUR', 'GBP', 'TRY', 'CAD', 'XDR', 'DKK', 'SEK', 'CHF', 'NOK', 'JPY', 'SAR', 'KWD', 'AUD', 'RUB', 'RON', 'PKR', 'IRR', 'CNY', 'BGN']
+    currencies = %w[ USD EUR GBP TRY CAD XDR DKK SEK CHF NOK
+                     JPY SAR KWD AUD RUB RON PKR IRR CNY BGN ]
     currencies.each do |c|
       CURRENCY_TYPE.create(currency: c.to_s)
     end
@@ -15,5 +15,4 @@ def self.up
   def self.down
     drop_table :currency_types
   end
-
-end
+end

lib/money/bank/tcmb_currency.rb

@@ -6,47 +6,32 @@
 
 class Money
   def exchange_to(to_currency, date = nil)
-    other_currency = Currency.wrap(to_currency)
     bank = Bank::TcmbCurrency.new
-    bank.exchange_with(self, to_currency, date)
+    bank.exchange_with!(self, to_currency, date)
   end
 
   module Bank
     class TcmbCurrency < Money::Bank::VariableExchange
-
       class CrossRate < ActiveRecord::Base
-
       end
 
       class CurrencyType < ActiveRecord::Base
-
       end
 
       attr_reader :rates
 
-      def flush_rates
-        @mutex.synchronize {
-          @rates = {}
-        }
-      end
-
-
-      def flush_rate(from, to)
-        key = rate_key_for(from,to)
-        @mutex.synchronize {
-          @rates.delete(key)
-        }
-      end
-
-      def exchange_with(*args)
-        from, to_currency, date = args[0], args[1], args[2]
+      def exchange_with!(*args)
+        from = args[0]
+        to_currency = args[1]
+        date = args[2]
         return from if same_currency?(from.currency, to_currency)
-        rate = get_rate(from.currency, to_currency, date)
+        rate = fetch_rate!(from.currency, to_currency, date)
         unless rate
-          raise UnknownRate, "No conversion rate known for '#{from.currency.iso_code}' -> '#{to_currency}'"
+          raise UnknownRate, "No conversion rate known for
+                '#{from.currency.iso_code}' -> '#{to_currency}'"
         end
-        _to_currency_ = Currency.wrap(to_currency)
-        fractional = BigDecimal.new(from.fractional.to_s) / (BigDecimal.new(from.currency.subunit_to_unit.to_s) / BigDecimal.new(_to_currency_.subunit_to_unit.to_s))
+        wrap_to_currency_ = Currency.wrap(to_currency)
+        fractional = get_fractional(from, wrap_to_currency_)
         ex = (fractional * BigDecimal.new(rate.to_s)).to_f
         ex = if block_given?
                yield ex
@@ -55,31 +40,37 @@ def exchange_with(*args)
              else
                ex.to_s.to_i
              end
-        Money.new(ex, _to_currency_)
-      end
-
-      def get_rate(from, to, date)
-        @mutex.synchronize {
-          @rates[rate_key_for(from, to)] ||= fetch_rate(from, to, date)
-        }
+        Money.new(ex, wrap_to_currency_)
       end
 
       private
 
-      def fetch_rate(from, to, date)
-        from, to = Currency.wrap(from), Currency.wrap(to)
+      def get_fractional(from, to_currency)
+        bd_from_fractional = BigDecimal.new(from.fractional.to_s)
+        bd_from_currency = BigDecimal.new(from.currency.subunit_to_unit.to_s)
+        bd_to_currency = BigDecimal.new(to_currency.subunit_to_unit.to_s)
+        bd_from_fractional / (bd_from_currency / bd_to_currency)
+      end
+
+      def fetch_rate!(from, to, date)
+        from_to_s = Money::Currency.wrap(from).to_s
+        to_to_s = Money::Currency.wrap(to).to_s
+        from_rate = 1.0
+        to_rate = 1.0
+        froms = Money::Bank::TcmbCurrency::CrossRate.where(code: from_to_s)
+        tos = Money::Bank::TcmbCurrency::CrossRate.where(code: to_to_s)
         if date.nil?
-          f = CrossRate.where(code: from.to_s).last
-          t = CrossRate.where(code: to.to_s).last
+          from_rate = froms.last.rate.to_f unless from_to_s == 'USD'
+          to_rate = tos.last.rate.to_f unless to_to_s == 'USD'
         else
-          f = CrossRate.where(code: from.to_s, date: date).last
-          t = CrossRate.where(code: to.to_s, date: date).last
+          unless Money::Bank::TcmbCurrency::CrossRate.where(date: date).present?
+            raise 'There is no record in that date.'
+          end
+          from_rate = froms.where(date: date).last.rate.to_f unless from_to_s == 'USD'
+          to_rate = tos.where(date: date).last.rate.to_f unless to_to_s == 'USD'
         end
-
-        return rate = t.rate.to_f/f.rate.to_f
+        to_rate / from_rate
       end
-      
     end
   end
 end
-

lib/tasks/tcmb_currency.rake

@@ -1,41 +1,41 @@
 namespace :tcmb_currency do
- desc 'insert tcmb_currency rates to db'
-  task :insert_from_tcmb => [:environment] do
-    require "nokogiri"
-    require "open-uri"
+  desc 'insert tcmb_currency rates to db'
+  task insert_from_tcmb: [:environment] do
+    require 'nokogiri'
+    require 'open-uri'
     @doc = Nokogiri::XML(open('http://www.tcmb.gov.tr/kurlar/today.xml'))
-    @code = Array.new
-    @doc.css("Currency").each do |response_node|
-      @code.push(response_node["Kod"])
+    @code = []
+    @doc.css('Currency').each do |response_node|
+      @code.push(response_node['Kod'])
     end
     @data = @doc.xpath('//Currency')
-    @currency = Hash.new
-    i=0
-    while i<@code.length
-      cross = ""
-      if @data[i].css('CrossRateUSD').children.to_s == ""
-        cross = 1.to_f/@data[i].css('CrossRateOther').children.to_s.to_f
-      else
-        cross = @data[i].css('CrossRateUSD').children.to_s
-      end
+    @currency = {}
+    i = 0
+    while i < @code.length
+      cross = ''
+      cross = if @data[i].css('CrossRateUSD').children.to_s == ''
+                1.to_f / @data[i].css('CrossRateOther').children.to_s.to_f
+              else
+                @data[i].css('CrossRateUSD').children.to_s
+              end
       cross = cross.to_f.round(4)
-      if cross.to_s != "Infinity"
+      if cross.to_s != 'Infinity'
         @currency = {
-            :code => @code[i],
-            :name => @data[i].css('CurrencyName').children.to_s.encode('UTF-8'),
-            :rate => cross.to_s,
-            :date => Time.now.to_date
+          code: @code[i],
+          name: @data[i].css('CurrencyName').children.to_s.encode('UTF-8'),
+          rate: cross.to_s,
+          date: Time.now.to_date
         }
         Money::Bank::TcmbCurrency::CrossRate.create!(@currency)
       end
       i += 1
     end
     @currency = {
-        :code => "TRY",
-        :name => "Turkish Lira",
-        :rate => @data[0].css('ForexBuying').children.to_s.to_f.round(4),
-        :date => Time.now.to_date
+      code: 'TRY',
+      name: 'Turkish Lira',
+      rate: @data[0].css('ForexBuying').children.to_s.to_f.round(4),
+      date: Time.now.to_date
     }
     Money::Bank::TcmbCurrency::CrossRate.create(@currency)
   end
-end
+end

lib/tcmb_currency.rb

@@ -1,6 +1,6 @@
-require "tcmb_currency/version"
-require "active_support/dependencies"
+require 'tcmb_currency/version'
+require 'active_support/dependencies'
 
 module TcmbCurrency
   require 'tcmb_currency/railtie' if defined?(Rails)
-end
+end

lib/tcmb_currency/railtie.rb

@@ -5,7 +5,7 @@ class Railtie < Rails::Railtie
     railtie_name :tcmb_currency
 
     rake_tasks do
-      load "tasks/tcmb_currency.rake"
+      load 'tasks/tcmb_currency.rake'
     end
   end
-end
+end

lib/tcmb_currency/version.rb

@@ -1,3 +1,3 @@
 module TcmbCurrency
-  VERSION = '0.4.0'
+  VERSION = '0.4.0'.freeze
 end