Skip to content

Ollama: improve Spring Boot starter tests #2101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
langchain4j opened this issue Nov 13, 2024 · 2 comments · May be fixed by langchain4j/langchain4j-spring#75
Open

Ollama: improve Spring Boot starter tests #2101

langchain4j opened this issue Nov 13, 2024 · 2 comments · May be fixed by langchain4j/langchain4j-spring#75
Labels
enhancement New feature or request good first issue Good for newcomers Spring Boot

Comments

@langchain4j
Copy link
Collaborator

https://github.com/langchain4j/langchain4j-spring/blob/main/langchain4j-ollama-spring-boot-starter/src/test/java/dev/langchain4j/ollama/spring/AutoConfigIT.java should be improved to use testcontainers:ollama and official ollama models
@langchain4j langchain4j added enhancement New feature or request good first issue Good for newcomers Spring Boot labels Nov 13, 2024
@Martin7-1 Martin7-1 linked a pull request Nov 15, 2024 that will close this issue
Open
@aTibrewala
Copy link

@dliubarskyi if this is still open, I would like to work on this

@dliubarskyi
Copy link
Member

@aTibrewala there is a PR already: langchain4j/langchain4j-spring#75
Please ping the author and see what can be done to complete it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers Spring Boot
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Uses official ollama testcontainers Martin7-1/langchain4j-spring
2 participants
@dliubarskyi @aTibrewala